Fix duplicate activated collection ids

planetarium · Apr 3, 2024 · 307023c · 307023c
1 parent 8dda29c
commit 307023c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.Lib9c.Tests/Model/State/CollectionStateTest.cs b/.Lib9c.Tests/Model/State/CollectionStateTest.cs
@@ -18,6 +18,8 @@ public void Bencoded()
                 {
                     1,
                     2,
+                    1,
+                    2,
                 },
             };
 
@@ -27,7 +29,7 @@ public void Bencoded()
             Assert.Equal(expected, serialized);
 
             var deserialized = new CollectionState(serialized);
-            Assert.Equal(state.Ids, deserialized.Ids);
+            Assert.Equal(new List<int> { 1, 2, }, deserialized.Ids);
         }
     }
 }
diff --git a/Lib9c/Model/State/CollectionState.cs b/Lib9c/Model/State/CollectionState.cs
@@ -1,4 +1,5 @@
 using System.Collections.Generic;
+using System.Linq;
 using Bencodex;
 using Bencodex.Types;
 using Nekoyume.Model.Stat;
@@ -24,13 +25,15 @@ public CollectionState(List serialized)
             {
                 Ids.Add((Integer)value);
             }
+
+            Ids = Ids.Distinct().ToList();
         }
 
         public CollectionState(IValue bencoded) : this((List)bencoded)
         {
         }
 
-        public IValue Bencoded => List.Empty.Add(new List(Ids));
+        public IValue Bencoded => List.Empty.Add(new List(Ids.Distinct()));
 
         public List<StatModifier> GetModifiers(CollectionSheet collectionSheet)
         {