Merge pull request #2491 from planetarium/hotfix/duplicate-collection

Validate collection id already activated
planetarium · Mar 26, 2024 · 2f676d7 · 2f676d7
2 parents 0a369cb + b283b6f
commit 2f676d7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.Lib9c.Tests/Action/ActivateCollectionTest.cs b/.Lib9c.Tests/Action/ActivateCollectionTest.cs
@@ -136,6 +136,12 @@ public void Execute()
 
             var nextAvatarState = nextState.GetAvatarState(_avatarAddress);
             Assert.Empty(nextAvatarState.inventory.Items);
+
+            Assert.Throws<AlreadyActivatedException>(() => activateCollection.Execute(new ActionContext
+            {
+                PreviousState = nextState,
+                Signer = _agentAddress,
+            }));
         }
     }
 }
diff --git a/Lib9c/Action/ActivateCollection.cs b/Lib9c/Action/ActivateCollection.cs
@@ -49,6 +49,10 @@ public override IWorld Execute(IActionContext context)
                 var itemSheet = sheets.GetItemSheet();
                 foreach (var (collectionId, collectionMaterials) in CollectionData)
                 {
+                    if (collectionState.Ids.Contains(collectionId))
+                    {
+                        throw new AlreadyActivatedException($"{collectionId} already activated.");
+                    }
                     var row = collectionSheet[collectionId];
                     foreach (var requiredMaterial in row.Materials)
                     {