Update Buff Icon Add #4940
Merged
Update Buff Icon Add #4940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NineSyu
requested review from
sonohoshi,
eugene-doobu,
tyrosine1153 and
jonny-jeahyunchoi
Closed
| @@ -213,6 +213,12 @@ MonoBehaviour: | |||
| type: 3} | |||
| BuffVFX: {fileID: 5068662467704735941, guid: 36d05c79df5e4a847934261885229a83, | |||
| type: 3} | |||
| - Id: 707001 | |||
There was a problem hiding this comment.
아이템을 추가하기보다 위 707000 ID로 설정된 아이템의 ID를 707001로 바꾸는게 맞아보입니다
There was a problem hiding this comment.
기존아이템이 변경되는게아니라서 신규로 추가하는게 맞아보여요~!
https://github.com/planetarium/lib9c/blob/c93e993e16713fb3ed43e1683b4beb0ccf0c6a69/Lib9c/TableCSV/Skill/ActionBuffSheet.csv#L11
비슷한내용으로 출혈 및 기절같은경우도 아이디에따라서 추가되어있습니다.
There was a problem hiding this comment.
707001로 올려야 하는 ID를 707000로 올린것으로 보였습니다
There was a problem hiding this comment.
707000은 8월드 장비에서 사용하는 버프 ID이며 707001은 룬에서 사용하는 버프 ID로 서로 다른 목적으로 사용하는 버프 ID입니다.
jonny-jeahyunchoi
approved these changes
May 22, 2024
eugene-doobu
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Buff Icon Add