-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unified dockerfile that supports multi arch #2599
Conversation
solves #2585 |
updated code as per review comments. Please check - thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution! Thanks to your contribution, we would become able to build Docker image with single Dockerfile!! 🚀
We're now operating Modathon 2024 (Nine Chronicles Hackathon) with a prize pool about $10,000. If you're interested, please take a look at the following items 🙏🏻
Head branch was pushed to by a user without write access
fails on install dependencies step 😢 |
@hriprsd Ah that's a problem with the Libplanet dependency. Looks like we'll have to fix that separately. |
It will be resolved by using https://github.com/planetarium/libplanet/releases/tag/5.3.1 and I have opened a new PR planetarium/lib9c#2898 to apply it to Lib9c. After the PR is merged, I'll bump the Lib9c submodule and this PR will be resolved as well. |
Thanks , hoping this will be done by October end 🤞 #hacktoberfest |
A PR that fixes the original issue has been merged into the development branch - this PR will probably succeed soon! |
gh workflow has been updated as well - with proper build args