Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unified dockerfile that supports multi arch #2599

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

hriprsd
Copy link
Contributor

@hriprsd hriprsd commented Oct 9, 2024

gh workflow has been updated as well - with proper build args

@auto-assign auto-assign bot requested review from area363, ipdae and moreal October 9, 2024 10:25
@CLAassistant
Copy link

CLAassistant commented Oct 9, 2024

CLA assistant check
All committers have signed the CLA.

@hriprsd
Copy link
Contributor Author

hriprsd commented Oct 9, 2024

solves #2585

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@hriprsd hriprsd requested a review from moreal October 15, 2024 05:35
@hriprsd
Copy link
Contributor Author

hriprsd commented Oct 15, 2024

updated code as per review comments. Please check - thanks!

Copy link
Contributor

@moreal moreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution! Thanks to your contribution, we would become able to build Docker image with single Dockerfile!! 🚀


We're now operating Modathon 2024 (Nine Chronicles Hackathon) with a prize pool about $10,000. If you're interested, please take a look at the following items 🙏🏻

@moreal moreal enabled auto-merge October 15, 2024 06:18
.github/workflows/push_docker_image.yml Outdated Show resolved Hide resolved
.github/workflows/push_docker_image.yml Outdated Show resolved Hide resolved
auto-merge was automatically disabled October 15, 2024 06:34

Head branch was pushed to by a user without write access

@hriprsd
Copy link
Contributor Author

hriprsd commented Oct 15, 2024

fails on install dependencies step 😢

@moreal
Copy link
Contributor

moreal commented Oct 15, 2024

fails on install dependencies step 😢

@hriprsd Ah that's a problem with the Libplanet dependency. Looks like we'll have to fix that separately.

@moreal
Copy link
Contributor

moreal commented Oct 15, 2024

It will be resolved by using https://github.com/planetarium/libplanet/releases/tag/5.3.1 and I have opened a new PR planetarium/lib9c#2898 to apply it to Lib9c. After the PR is merged, I'll bump the Lib9c submodule and this PR will be resolved as well.

@hriprsd
Copy link
Contributor Author

hriprsd commented Oct 15, 2024

It will be resolved by using https://github.com/planetarium/libplanet/releases/tag/5.3.1 and I have opened a new PR planetarium/lib9c#2898 to apply it to Lib9c. After the PR is merged, I'll bump the Lib9c submodule and this PR will be resolved as well.

Thanks , hoping this will be done by October end 🤞 #hacktoberfest

@moreal
Copy link
Contributor

moreal commented Oct 17, 2024

A PR that fixes the original issue has been merged into the development branch - this PR will probably succeed soon!

@moreal moreal linked an issue Oct 17, 2024 that may be closed by this pull request
3 tasks
@moreal moreal merged commit 1c74e28 into planetarium:development Oct 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Unify Dockerfiles for multi-platforms
3 participants