-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate collection cp in arena list #2408
Conversation
Co-authored-by: Lee Dogeon <[email protected]>
Replace `--network-type` with `--planet`
bump lib9c to dev
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
…eadless into improve/issue-2400
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e987be8
이 커밋까진 아레나에서 cp 계산하는거랑 별개로 섞인 변경사항들인걸까요?
네 development 범프가 필요해서 풀하면서 따라온것처럼 보입니다. fec0915, 877bd65 2 커밋만 봐주시면 됩니다. @sonohoshi |
@@ -160,8 +161,10 @@ await CoconaLiteApp.CreateHostBuilder() | |||
bool? strictRendering = null, | |||
[Option(Description = "Log action renders besides block renders. --rpc-server implies this.")] | |||
bool? logActionRenders = null, | |||
[Option("network-type", Description = "Network type.")] | |||
NetworkType? networkType = null, | |||
[Option("network-type", Description = "(deprecated) Network type.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요건 deprecated되었음을 더 명확히 해주는 어트리뷰트같은거 적용 할 수 없을까요?
resolve #2400