Arena GQL Simulator - Win % calculator

[FioX0]

Please note that this might be a bit of a resource intensive query. It performs quite well on my Dev PC, but on my VPS I do see a bit of a slowdown but the VPS isn't really strong to begin with.

I have optimized this as much as I could. Might not be suitable for production, but letting planetarium to make that decision.

This allows you to provide 2 AvatarAddresses and it will simulate 1000 fights and return a decimal which would be the % of avatar1 winning against Avatar2.

query{ stateQuery{ arenaPercentageCalculator(avatarAddress:"0x3b7a47daaece48807fc00a310b05bd9f5d26736e", enemyAvatarAddress:"0xab44635462880666daa7f2be5a21c71c1590ff2b") } }

{ "data": { "stateQuery": { "arenaPercentageCalculator": 3 } }, "extensions": {} }

[longfin]

I guess stateQuery might not be the best place for this sort of query because it seems very domain specific(i.e., PVP system) logic instead of simple state lookups. (but on the other hand, it isn't strong due to a lack of alternatives 😅 ) cc @planetarium/nine-chronicles

[FioX0]

May I suggest a new category called "simulatorQuery"? I also got a Stage/PVE one that is almost done. So both queries could be set under this new category.

[longfin]

it would be nice if we have an option for this iteration count as configurable.

[FioX0]

Will add this right away, I'm thinking of making a hard cap of 5000? It gets quite resource intensive.

[longfin]

introducing a hard cap would be nice! I don't have an appropriate number for that, but both 1k and 5k are looks good to me.

[longfin]

Returning aggregated summary makes sense but I also think that more detailed information might be more helpful.

e.g.,

{
    "blockIndex": 1,
    "result": [
        {
            "seed": 1234,
            "win": true
        },
        {
            "seed": 5678,
            "win": false
        },
    ]
}

[FioX0]

Thanks Swen.

So BlockIndex,
Percentage and then a
Results List per seed/win state?

Then user can decide if they want the result list?

[longfin]

• blockIndex may be needed to determine what sheet states we have referred.
• seed can be used for local validation as you said. 😄

[FioX0]

@longfin
Like so?

{
  "data": {
    "simulationQuery": {
      "arenaPercentageCalculator": {
        "blockIndex": 7133512,
        "result": [
          {
            "seed": 1893608300,
            "win": true
          },
          {
            "seed": 2073532131,
            "win": true
          },
          {
            "seed": 1826085108,
            "win": false
          },
          {
            "seed": 1985649038,
            "win": false
          },
          {
            "seed": 614892139,
            "win": true
          },
          {
            "seed": 2060699251,
            "win": false
          },
          {
            "seed": 784343549,
            "win": true
          },
          {
            "seed": 2109394172,
            "win": true
          },
          {
            "seed": 1339463095,
            "win": true
          },
          {
            "seed": 1834517228,
            "win": false
          }
        ],
        "winPercentage": 60
      }
    }
  },
  "extensions": {}
}

GQL Query as per below:

query{
  simulationQuery{
    arenaPercentageCalculator(avatarAddress:"0x63b6fef274118719790f63865e63a2cd26ff14dc", enemyAvatarAddress:"0x63b6fef274118719790f63865e63a2cd26ff14dc", simulationCount:10){
      blockIndex,result{seed,win},winPercentage
    }
  }
}

[longfin]

@FioX0 right 😄

[pull-request-quantifier-deprecated]

This PR has 223 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Large
Size       : +222 -1
Percentile : 62.3%

Total files changed: 9

Change summary by file extension:
.cs : +222 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.