Championship arena GQL update #1415

TarogStar · 2022-07-06T02:21:44Z

I added some additional models, added the chain tip index to the StateContext, and inherited from IAccountStateDelta to allow all of the extension methods to get the arena data. The old weekly arena is still available to get data for older arena rounds.

Additional state extension methods are available if the context is also IAccountStateDelta

ipdae

Thanks for your contribution. I have a few questions, so I left a comment.

ipdae · 2022-07-11T03:01:22Z

NineChronicles.Headless/GraphTypes/States/StateContext.cs

 using Bencodex.Types;
 using Libplanet;
 using Libplanet.Action;
 using Libplanet.Assets;

 namespace NineChronicles.Headless.GraphTypes.States
 {
-    public class StateContext
+    public class StateContext : IAccountStateDelta


Is there any reason to inherit from IAccountStateDelta? I wonder where it is used.

IAccountStateDelta allows using GetSheets, TryGetArenaParticipants, TryGetArenaInformation, TryGetArenaScore Would it make sense to just import those methods and duplicate them in the StateContext?

ipdae · 2022-07-11T04:10:15Z

NineChronicles.Headless/GraphTypes/StandaloneQuery.cs

@@ -54,7 +54,8 @@ public StandaloneQuery(StandaloneContext standaloneContext, IConfiguration confi

                    return new StateContext(
                        chain.ToAccountStateGetter(blockHash),
-                        chain.ToAccountBalanceGetter(blockHash)
+                        chain.ToAccountBalanceGetter(blockHash),
+                        chain.Tip.Index


Even when a block hash is given as an argument, but block index always use latest index. it may cause confusion.

I submitted a new commit to address the issue to use the right block index.

ipdae · 2022-07-11T04:13:27Z

NineChronicles.Headless/GraphTypes/States/StateContext.cs

        {
            AccountStateGetter = accountStateGetter;
            AccountBalanceGetter = accountBalanceGetter;
+            ChainTipIndex = chainTipIndex;


Where is chainTipIndex used? I can't see where it's used, is there a reason it was added?

It looks like I didn't get everything over to this branch previously. I needed the index to determine if 0 tickets is actually 0 or should be 8 and they haven't battled since the reset. I have now included the code that uses the index.

boscohyun · 2022-07-11T04:58:47Z

NineChronicles.Headless/GraphTypes/StateQuery.cs

+                        arenaInfo.Ticket = arenaInformation.Ticket;
+                        arenaInfo.Lose = arenaInformation.Lose;
+                        arenaInfo.Score = arenaScore.Score;
+                        arenaInformations.Add(arenaInfo);


If you want to sorting this arenaInformations same with client, and check this function.

Ranking is determined by score.

The same score is displayed in the same rank.

The same rank at this time is the sum of the number of equal ranks from the previous rank.

The next rank of the same rank is the next rank of the same rank.

e.g., You can check what we expect with Data source and Unit test

And we will move this ranking function from 9c to lib9c

I have added the proper ranking and sorting to the PR. Will need to modify when the function moves to lib9c to keep it consistent.

…uild error.

ipdae

i can't understand ordering of ChampionArenaInfo please check @boscohyun

…date

Additional state extension methods are available if the context is also IAccountStateDelta

…query

TarogStar · 2022-07-27T20:42:00Z

I ran some tests and made sure that rank was exposed and properly calculated vs client and corrected some issues with the code and also merged in the latest from the development branch.

…date

…rogStar/NineChronicles.Headless into Championship-Arena-Gql-Update

Merge `rc-v100351` into `main`

…to-main

…-main Merge `rc-v100360-1` to main

bump lib9c (main)

Fix release workflow bug

fix syntax error

⬆️ Bump lib9c v100361

⬆️ [rc-v100370] Bump lib9c

Bump Lib9c v100361 # -----BEGIN PGP SIGNATURE----- # # iQIzBAABCAAdFiEESrITiRCjYKFI2nN2C4+hGGGQlhQFAmPczjcACgkQC4+hGGGQ # lhTh9BAAiOhler1K9YKEKOOxuSJ2u4HsCvqTqF8C42drnx75TADUG8lS720QlA4c # B0TlzTxCkohCDGjQ74a4DPddzh9j8WH+IOlXEyGLbLy+M8r3oRhcePbs3pv/rTCU # Ym1t0dvWkgHB5RbGTDrzKV/AHM3PVoM6UI4HbIkbBVk7Z3vDzHM8KNqfT1MX7R2q # oxRwbdQoiFuZPzu5HADtvIPS6ObZy12/l4JBGCaDjImmFFeogaT3gKTyYPKm20r0 # NHtWlE07Rg52qdlWofFxhDQ8PWQ6bJWkObQB534Qd3CjUdKPXXSU8AjK5pOA2yQH # aURgoJRD76lY5ph2GK8ASdj49KNZuF4+/ZE/6bDEjxqz/UepGq/PFCSm4z97GAmW # V7EIQ2FtKVnoCsVDIYv9eU6rexK7grs5ghvYQegG/yYIDGcrACopNe8DnFa32tPc # /c2+N77WZ8braeFsw70ojKFaDzkLtZXWwARrtTcTmlDcd8I3jupbTazTrbGhIzPQ # v+XW5DupUY9QNEn4KNhpopyApE3MyAo4DNrsW9lEjCPjVZBGF5IG5MTIRSFKlj/2 # HeBZSJ1WSDXDifc/9tTRrhTCDjCv6bvOO7vsT90a4C+W8MASwA7/n1gq6sQUyOaP # QYBTiOLHBEMFSXeVRVPbGsXAxOgsJmHwyey/kyoEzfiYzLXzheU= # =jlhk # -----END PGP SIGNATURE----- # gpg: Signature made Fri Feb 3 18:04:55 2023 # gpg: using RSA key 4AB2138910A360A148DA73760B8FA11861909614 # gpg: Can't check signature: No public key

merge rc-v100370-1 into main

Bump lib9c v100371

pull-request-quantifier-deprecated · 2023-03-04T16:48:31Z

This PR has 245 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Large
Size       : +240 -5
Percentile : 64.5%

Total files changed: 9

Change summary by file extension:
.sln : +0 -0
.cs : +239 -4
Lib9c : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

TarogStar added 6 commits July 5, 2022 20:00

Additional State models for new arena

bc4cb2a

Allow additional state extension methods

2958d67

Additional state extension methods are available if the context is also IAccountStateDelta

Add GQL query for Champion Arena state

b43b3f9

Add Tip to StateContext

f2bba4f

Add chainTip to StateContext

49f5160

Add chainTip to StateContext

b47b0f1

auto-assign bot requested a review from moreal July 6, 2022 02:21

auto-assign bot assigned TarogStar Jul 6, 2022

pull-request-quantifier-deprecated bot added the Medium label Jul 6, 2022

longfin requested review from boscohyun, hskim881028 and ipdae July 6, 2022 11:49

TarogStar added 3 commits July 8, 2022 15:55

Update some references, rename chainTip to chainTipIndex

f186a56

Merge branch 'development' into Championship-Arena-Gql-Update

627e804

Fix tests

e7fdfd9

ipdae reviewed Jul 11, 2022

View reviewed changes

boscohyun reviewed Jul 11, 2022

View reviewed changes

TarogStar added 4 commits July 11, 2022 22:52

Pass the right block index if a block hash is passed.

3b523fa

Update to include avatar name, agent address, and proper ticket value.

ae88be6

Only get the currentTicketResetCount once.

cf23795

Order the arena Information properly, merge if statement for ubunut b…

df54b4f

…uild error.

pull-request-quantifier-deprecated bot added Large and removed Medium labels Jul 12, 2022

ipdae reviewed Jul 18, 2022

View reviewed changes

TarogStar added 6 commits July 27, 2022 01:47

Merge branch 'planetarium:development' into Championship-Arena-Gql-Up…

b92301d

…date

Additional State models for new arena

5297935

Allow additional state extension methods

d86695b

Additional state extension methods are available if the context is also IAccountStateDelta

Add GQL query for Champion Arena state

33e07a8

Add Tip to StateContext

c2ab3df

Add chainTip to StateContext

4d897c1

Allow null blockindex for statecontext. Fix type issues and ordering …

5bbcb70

…query

TarogStar and others added 27 commits July 28, 2022 16:26

Fix purchased ticket count

4d1f909

Add Arena Equipment and Costumes to Arena Query

1422efe

Merge branch 'planetarium:development' into Championship-Arena-Gql-Up…

093cc8e

…date

fix parameter name

97f936d

Merge branch 'Championship-Arena-Gql-Update' of https://github.com/Ta…

22c1ba0

…rogStar/NineChronicles.Headless into Championship-Arena-Gql-Update

Merge branch 'development' into Championship-Arena-Gql-Update

3c8b32f

Merge pull request planetarium#1824 from planetarium/rc-v100351

1ef1479

Merge `rc-v100351` into `main`

Merge remote-tracking branch 'upstream/main' into merge-rc-v100360-1-…

2cf7e01

…to-main

Merge pull request planetarium#1863 from moreal/merge-rc-v100360-1-to…

ffdc71c

…-main Merge `rc-v100360-1` to main

bump lib9c

977bdff

Merge pull request planetarium#1867 from planetarium/bump-lib9c-230201

c6136e1

bump lib9c (main)

Fix release workflow bug

cdfbb11

Merge pull request planetarium#1868 from moreal/fix-release-job

47fb280

Fix release workflow bug

fix syntax error

5dce23e

Merge pull request planetarium#1873 from area363/fix-docker-tagging

179a3ee

fix syntax error

bump: lib9c v100361

f1a02ca

Merge pull request planetarium#1878 from planetarium/bump/lib9c/v100361

2e81c7d

⬆️ Bump lib9c v100361

Merge v100361-2

36e2442

Bump lib9c

18594d0

Merge pull request planetarium#1901 from greymistcube/bump/lib9c

d940250

⬆️ [rc-v100370] Bump lib9c

bump lib9c to main

0c1be04

Merge pull request planetarium#1907 from planetarium/rc-v100370-1

6830eba

merge rc-v100370-1 into main

Bump lib9c v100371

f8e0e9d

Merge pull request planetarium#1910 from ipdae/rc-v100371

6483167

Bump lib9c v100371

Merge tag 'v100371-1' into Championship-Arena-Gql-Update

4800bce

minor update

2f44695

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Championship arena GQL update #1415

Championship arena GQL update #1415

TarogStar commented Jul 6, 2022

ipdae left a comment

ipdae Jul 11, 2022

TarogStar Jul 12, 2022

ipdae Jul 11, 2022

TarogStar Jul 12, 2022

ipdae Jul 11, 2022

TarogStar Jul 12, 2022

boscohyun Jul 11, 2022 •

edited

Loading

TarogStar Jul 12, 2022

ipdae left a comment

TarogStar commented Jul 27, 2022

pull-request-quantifier-deprecated bot commented Mar 4, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Championship arena GQL update #1415

Are you sure you want to change the base?

Championship arena GQL update #1415

Conversation

TarogStar commented Jul 6, 2022

ipdae left a comment

Choose a reason for hiding this comment

ipdae Jul 11, 2022

Choose a reason for hiding this comment

TarogStar Jul 12, 2022

Choose a reason for hiding this comment

ipdae Jul 11, 2022

Choose a reason for hiding this comment

TarogStar Jul 12, 2022

Choose a reason for hiding this comment

ipdae Jul 11, 2022

Choose a reason for hiding this comment

TarogStar Jul 12, 2022

Choose a reason for hiding this comment

boscohyun Jul 11, 2022 • edited Loading

Choose a reason for hiding this comment

TarogStar Jul 12, 2022

Choose a reason for hiding this comment

ipdae left a comment

Choose a reason for hiding this comment

TarogStar commented Jul 27, 2022

pull-request-quantifier-deprecated bot commented Mar 4, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

boscohyun Jul 11, 2022 •

edited

Loading