Add explanation to FAV comparison

planetarium · Nov 3, 2023 · 1b3f712 · 1b3f712
1 parent 5d29794
commit 1b3f712
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/NineChronicles.Headless.Tests/GraphTypes/ActionQueryTest.cs b/NineChronicles.Headless.Tests/GraphTypes/ActionQueryTest.cs
@@ -1413,6 +1413,13 @@ public async Task ClaimItems(int claimDataCount)
                 Assert.Equal(expectedFavList.Count, actualFavList.Count);
                 for (var j = 0; j < expectedFavList.Count; j++)
                 {
+                    /* FIXME: Make Assert.Equal(FAV1, FAV2) works.
+                     This test will fail because:
+                         - GQL currency type does not allow `null` as minters to you should give empty list.
+                         - But inside `Currency`, empty list is changed to null.
+                         - As a result, currency hash are mismatch.
+                         - See https://github.com/planetarium/NineChronicles.Headless/pull/2282#discussion_r1380857437
+                    */
                     // Assert.Equal(expectedFavList[i], actualFavList[i]);
                     Assert.Equal(expectedFavList[j].Currency.Ticker, actualFavList[j].Currency.Ticker);
                     Assert.Equal(expectedFavList[j].RawValue, actualFavList[j].RawValue);