Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct broken chart #2265

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: correct broken chart #2265

merged 1 commit into from
Dec 19, 2024

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Dec 19, 2024 •
edited
Loading

I tested with the following command:

helm template name ./charts/all-in-one --values ./charts/all-in-one/values.yaml --values ./9c-main/multiplanetary/network/general.yaml --values ./9c-main/multiplanetary/network/9c-network.yaml
  • Setup default value in values.yaml
  • Fix typo (.testHeadless. → .testHeadless1)

@moreal moreal added the bug Something isn't working label Dec 19, 2024
@moreal moreal self-assigned this Dec 19, 2024
@auto-assign auto-assign bot requested review from area363, eseiker and sky1045 December 19, 2024 00:39
area363
area363 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@area363 area363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@moreal moreal force-pushed the bugfix/remote-kv-default-value branch from 50df685 to e0ec043 Compare December 19, 2024 00:44
@moreal moreal merged commit 294cf2d into planetarium:main Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@area363 area363 area363 approved these changes

@eseiker eseiker eseiker approved these changes

@sky1045 sky1045 Awaiting requested review from sky1045

Assignees

@moreal moreal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moreal @eseiker @area363