-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to TinyMCE7 #9366
Labels
Housekeeping:1:Todo
Any dependency management or refactor that would be nice to have some day.
Milestone
Comments
jardakotesovec
added
the
Housekeeping:1:Todo
Any dependency management or refactor that would be nice to have some day.
label
Oct 2, 2023
This was referenced Oct 16, 2023
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 6, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 6, 2025
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 6, 2025
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 6, 2025
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 6, 2025
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 6, 2025
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 6, 2025
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 6, 2025
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 6, 2025
…e editor in Composer component
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 6, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 8, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 8, 2025
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 8, 2025
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 8, 2025
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 8, 2025
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 8, 2025
…e editor in Composer component
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 8, 2025
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 8, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 13, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 13, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 13, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 13, 2025
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 13, 2025
Once this gets merged, we can also close #9239. |
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 15, 2025
…e editor in Composer component
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 15, 2025
…hTextarea component
blesildaramirez
added a commit
to blesildaramirez/ui-library
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/pkp-lib
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ojs
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/omp
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/omp
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/omp
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ops
that referenced
this issue
Jan 15, 2025
blesildaramirez
added a commit
to blesildaramirez/ops
that referenced
this issue
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Housekeeping:1:Todo
Any dependency management or refactor that would be nice to have some day.
For next LTS we aim to have major dependencies all up to date. TinyMCE has not been updated while vue3 upgrade.
Merge requests:
ui-library: pkp/ui-library#477
pkp-lib: #10773
ojs: pkp/ojs#4578
omp: pkp/omp#1809
ops: pkp/ops#845
Notes:
We upgraded TinyMCE from v5.10.9 to v7.6.0
https://www.tiny.cloud/docs/tinymce/6/migration-from-5x/
https://www.tiny.cloud/docs/tinymce/latest/migration-from-6x/
editorManager.settings
was removed in v6. Workaround is to expose this settings by using$.pkp.controllers.SiteHandler.prototype.tinymceParams_
and set additional settings here.forced_root_block: ''
was also deprecated and removed in v6, we use this empty string value in our componentFieldRichText
. This means that by default for this component, we don't want to set any wrappers to our editor but with v6, TinyMCE sets a<p>
wrapper automatically. We remove this wrapper using the "PostProcess" event which is called before returning the.getContent()
API from TinyMCE. See forced_root_block deprecation tinymce/tinymce#7342 (comment) for more info. For the other component,FieldRichTextarea
, we originally don't set anything for theforced_root_block
. This means that by default, the editor will use the default wrapper<p>
, which is fine since this has been the default value even for lower version of TInyMCE.The text was updated successfully, but these errors were encountered: