Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FieldRichText formatting options not visible after migration to Vite/Vue3 #9390

Closed
NateWr opened this issue Oct 9, 2023 · 2 comments
Closed

FieldRichText formatting options not visible after migration to Vite/Vue3 #9390

NateWr opened this issue Oct 9, 2023 · 2 comments
Assignees
@jardakotesovec
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Milestone
3.5 Internal

Comments

@NateWr
Copy link
Contributor

NateWr commented Oct 9, 2023

Describe the bug
The FieldRichText field includes a button dropdown to show formatting options, like bold and italic. After the migration to Vite/Vue3, the button no longer appears.

To Reproduce
Steps to reproduce the behavior:

  1. Launch the ui library.
  2. Go to Form > FieldRichText
  3. Click on the input field.
  4. See that the formatting button doesn't appear

What application are you using?
main branch (pre-3.5)

Additional information
How it used to work:

field-rich-text.webm

How it works in main:

field-rich-text-broken.webm
@touhidurabir touhidurabir added the Bug:2:Moderate A bug that is causing problems for a substantial minority of users. label Oct 16, 2023
@touhidurabir touhidurabir added this to the 3.5.0 LTS milestone Oct 16, 2023
@touhidurabir
Copy link
Member

@jardakotesovec can you please take a look at this one . Probably would be a good idea to tackle this as a part of #9366 as we may need some modification to make it compatible with TinyMCE 6.0 .

@jardakotesovec jardakotesovec self-assigned this Oct 16, 2023
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Oct 16, 2023
@jardakotesovec
pkp/pkp-lib#9390 Fix FieldRich* to correctly get focus/blur from tiny…
a8dd4af 
…Mce (after vue3 upgrade)
jardakotesovec added a commit to pkp/ui-library that referenced this issue Oct 16, 2023
@jardakotesovec
pkp/pkp-lib#9390 Fix FieldRich* to correctly get focus/blur from tiny…
29d989a 
…Mce (after vue3 upgrade) (#291)
@jardakotesovec
Copy link
Contributor

@NateWr Thank you for the report. Addressed on ui-library main (pkp/ui-library#291). Should be ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jardakotesovec jardakotesovec

Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
3 participants
@jardakotesovec @NateWr @touhidurabir