-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OJS - 3.5 - Viewing submission without review stage will display an error when selecting review from side workflow navigation option #10626
Comments
@jardakotesovec I have updated the local branch and tried again. The UI no longer crashes with a grey background but an error is still present due to null object. Will add another screenshot for reference. Additionally, the there are added steps since the default already has the review option highlight you will first need to select another option and then back to the Review option. I will lower the severity as well. |
@jardakotesovec I added a fix for this. Please take a look. submodule updates |
@taslangraham I think this is already addressed on main branch.. as part of some other recent changes.. Overall still refining that area.. so was asking @Tribunal33 to hold with other reports until its ready for testing.. @Tribunal33 Can you confirm it? |
Or maybe it its not.. but in anycase thats with me :-) |
@jardakotesovec I'll close out those PRs then |
Describe the bug
When selecting the Review option from the side navigation workflow option within a submission view, that does not have a Review Round created results in an error and greyed out background blocking user.
To Reproduce
Steps to reproduce the behavior:
Actual:
Pane closes and grey background is unclickable for user.Error is in the dev tools (see updated image):Additional information
Please add any screenshots, logs or other information we can use to investigate this bug report.
Updated image
Old Image
The text was updated successfully, but these errors were encountered: