Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OJS - 3.5 - Viewing submission without review stage will display an error when selecting review from side workflow navigation option #10626

Open
Tribunal33 opened this issue Nov 20, 2024 · 5 comments
Assignees
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone

Comments

@Tribunal33
Copy link

Tribunal33 commented Nov 20, 2024

Describe the bug
When selecting the Review option from the side navigation workflow option within a submission view, that does not have a Review Round created results in an error and greyed out background blocking user.

To Reproduce
Steps to reproduce the behavior:

  1. Go to VM of you choice (ex https://jarda.testing.publicknowledgeproject.org/index.php/publicknowledge/en/)
  2. Login with any user (admin used for testing)
  3. Under Dashboards -> active submissions select a submission without a Review Round
  4. Select Rossi -> View button
  5. Open up dev tools to view console error
  6. From the new window pane Select Review from side nav Workflow option
  7. If error is not seen select different side nav option first then select Review option after
  8. Observe error in consoleExpected: No error and pane updates correctly

Actual: Pane closes and grey background is unclickable for user. Error is in the dev tools (see updated image):

Additional information
Please add any screenshots, logs or other information we can use to investigate this bug report.
Updated image
Image

Old Image
Image

@Tribunal33 Tribunal33 added the Bug:2:Moderate A bug that is causing problems for a substantial minority of users. label Nov 20, 2024
@Tribunal33 Tribunal33 added this to the 3.5.0 LTS milestone Nov 20, 2024
@Tribunal33
Copy link
Author

@jardakotesovec I have updated the local branch and tried again. The UI no longer crashes with a grey background but an error is still present due to null object. Will add another screenshot for reference.

Additionally, the there are added steps since the default already has the review option highlight you will first need to select another option and then back to the Review option.

I will lower the severity as well.

@Tribunal33 Tribunal33 added Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. and removed Bug:2:Moderate A bug that is causing problems for a substantial minority of users. labels Nov 20, 2024
taslangraham added a commit to taslangraham/ui-library that referenced this issue Nov 28, 2024
taslangraham added a commit to taslangraham/ui-library that referenced this issue Nov 28, 2024
@taslangraham taslangraham self-assigned this Nov 28, 2024
@taslangraham
Copy link
Contributor

@jardakotesovec I added a fix for this. Please take a look.
PRs
pkp/ui-library#453

submodule updates
pkp/ojs#4534
pkp/ops#820
pkp/omp#1778

@jardakotesovec
Copy link
Contributor

@taslangraham I think this is already addressed on main branch.. as part of some other recent changes.. Overall still refining that area.. so was asking @Tribunal33 to hold with other reports until its ready for testing..

@Tribunal33 Can you confirm it?

@jardakotesovec
Copy link
Contributor

Or maybe it its not.. but in anycase thats with me :-)

@taslangraham
Copy link
Contributor

@jardakotesovec I'll close out those PRs then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Development

No branches or pull requests

4 participants