New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix sending orcid validate email on create author action during … #321

Open

zielaq wants to merge 1 commit into pkp:main from zielaq:send_validation_mail_on_create_author

zielaq commented Aug 27, 2024

Sending verification email when creating author is not working (its only work on edit action)
changed few things.

authorform:execute seems to not be used any more
on Author::add hook calling same action as on edit
getting requestOrcidAuthorization and deleteORCID values from request (this is always available)
in sendAuthorMail removed condition for saving author as during ADD hook is called before saving author by core application, and in ADD hook its called after. thats why Repo::author()->dao->update($author); should be always called


          fix: fix sending orcid validate email on create author action during …

59e0a2d

…submission wizzard

Member

asmecher commented Aug 27, 2024

Thanks, @zielaq! @ewhanson, for your consideration...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet