Fix #6, #7 Login form is missing URL and password field is wrong type

pkp · Feb 12, 2018 · d0eea0b · d0eea0b
1 parent da573a8
commit d0eea0b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/HealthSciencesThemePlugin.inc.php b/HealthSciencesThemePlugin.inc.php
@@ -121,13 +121,23 @@ public function loadTemplateData($hookName, $args) {
 		$context = $request->getContext();
 
 		if (!defined('SESSION_DISABLE_INIT')) {
+
+			// Get possible locales
 			if ($context) {
 				$locales = $context->getSupportedLocaleNames();
 			} else {
 				$locales = $request->getSite()->getSupportedLocaleNames();
 			}
+
+			// Load login form
+			$loginUrl = $request->url(null, 'login', 'signIn');
+			if (Config::getVar('security', 'force_login_ssl')) {
+				$loginUrl = PKPString::regexp_replace('/^http:/', 'https:', $loginUrl);
+			}
+
 			$templateMgr->assign(array(
 				'languageToggleLocales' => $locales,
+				'loginUrl' => $loginUrl,
 				'brandImage' => 'templates/images/ojs_brand_white.png',
 			));
 		}

diff --git a/templates/frontend/components/loginForm.tpl b/templates/frontend/components/loginForm.tpl
@@ -37,7 +37,7 @@
 					{translate key="common.required"}
 				</span>
 			</label>
-			<input type="text" class="form-control" name="password" id="password" value="{$password|escape}" maxlength="32" required>
+			<input type="password" class="form-control" name="password" id="password" value="{$password|escape}" maxlength="32" required>
 		</div>
     <div class="row">
       <div class="col-md-6">