Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(typehints): replace string typehints #1289

Merged
merged 2 commits into from
Nov 13, 2023
Merged

style(typehints): replace string typehints #1289

merged 2 commits into from
Nov 13, 2023

Conversation

ReenigneArcher
Copy link
Contributor

Description

This PR replaces string typehints in mixins.py as discussed on the discord server. https://discord.com/channels/741380592104636467/741380592104636470/1171256731607769108

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

plexapi/mixins.py Outdated Show resolved Hide resolved
@JonnyWong16 JonnyWong16 merged commit 70b126f into pkkid:master Nov 13, 2023
5 checks passed
@ReenigneArcher ReenigneArcher deleted the style(typehints)-replace-string-typehints- branch November 16, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants