Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batchMultiEdits() for collections #1287

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

JonnyWong16
Copy link
Collaborator

Description

Fix batchMultiEdits() for collections.

  • Libraries have a collections() method which has the same name as media's collections attribute. Check that the tags are a list when adding tags together.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

Libraries have a `collections()` method which has the same name as media's `collections` attribute.
@sysmoon14
Copy link

I've just tested this locally and all seems well

@YozoraXCII
Copy link

Also tested and verified

@JonnyWong16 JonnyWong16 merged commit 2f888df into pkkid:master Nov 13, 2023
5 checks passed
@JonnyWong16 JonnyWong16 deleted the bugfix/library_batch_edits branch November 13, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants