-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix for #531 #533
base: beta
Are you sure you want to change the base?
fix: fix for #531 #533
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e651448:
|
I took a crack at a fix, and the failing test I submitted is now passing. I attempted to make the test more robust as well. The key to my fix is to use the resolved assets if they are already resolved by the time an additional hook is called. However, we may need a better test that validates that the texture has the correct data and does not simply return a default texture instance. This could potentially be verified via the width and height of the texture being mocked to something specific, and for good fun, increasing the timeout delay for resolving the promise in createImageBitmap. |
Description of change
Generates a failing test for issue #531
Potential fix for #531; please modify or review as necessary.
Fixes: #531
Pre-Merge Checklist
npm run lint
)npm run test
)