Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useTick during initial load when using server components #510

Merged

Conversation

trezy
Copy link
Collaborator

@trezy trezy commented Jul 29, 2024

Description of change

useTick failed to fire on the first tick in server-rendered environments (such as Next.js applications) because the useEffect wasn't being triggered. This is fixed by switching to use useIsomorphicLayoutEffect instead.`

Fixes: #506

Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

`useTick` was failing to fire on the first tick in server rendered
environments (such as Next.js applications) because the `useEffect`
wasn't being triggered. This is fixed by switching to use
`useIsomorphicLayoutEffect` instead.`

fixes #506
@trezy trezy added bug Something isn't working v8 Issues related to Pixi React v8 labels Jul 29, 2024
@trezy trezy self-assigned this Jul 29, 2024
@trezy trezy merged commit 43b471b into beta Jul 29, 2024
2 of 3 checks passed
@trezy trezy deleted the 506-bug-usetick-not-ticking-on-initial-load-during-vite-dev branch July 29, 2024 20:30
Copy link

🎉 This issue has been resolved in version 8.0.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released on @beta v8 Issues related to Pixi React v8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant