Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify internal types #508

Merged
merged 13 commits into from
Jul 26, 2024
Merged

Simplify internal types #508

merged 13 commits into from
Jul 26, 2024

Conversation

trezy
Copy link
Collaborator

@trezy trezy commented Jul 26, 2024

Description of change

All changes are related to typings

  • PixiReactNode is now used for both internal and internal types (eliminated Instance types)
  • PixiReactNode is now 1 type, rather than several
  • All internal types use HostConfig where appropriate (instances, props, etc); this will make it easier to update these types in the future
  • Event handlers are now explicitly typed with Pixi's FederatedEventHandler instead of usign a generic function signature with Federated* events
  • Removed a bunch of unused types
  • Updated names of several types to more accurately reflect their purposes
Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@trezy trezy added enhancement New feature or request v8 Issues related to Pixi React v8 labels Jul 26, 2024
@trezy trezy self-assigned this Jul 26, 2024
@trezy trezy merged commit b069788 into beta Jul 26, 2024
2 of 3 checks passed
@trezy trezy deleted the simplify-internal-types branch July 26, 2024 17:40
Copy link

🎉 This issue has been resolved in version 8.0.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released on @beta v8 Issues related to Pixi React v8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant