fix: disallow children from being passed to constructors

pixijs · Jun 15, 2024 · 2f25703 · 2f25703
1 parent ec3b6aa
commit 2f25703
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 19 deletions.
diff --git a/src/typedefs/HostConfig.js b/src/typedefs/HostConfig.js
@@ -1,9 +1,9 @@
 /** @typedef {import('./Instance.js').Instance} Instance */
-/** @typedef {import('../typedefs/PixiElements.js').PixiElements} PixiElements */
+/** @typedef {import('../typedefs/PixiElementsImpl.js').PixiElementsImpl} PixiElementsImpl */
 
 /**
  * @typedef {object} HostConfig
- * @property {keyof PixiElements} type
+ * @property {keyof PixiElementsImpl} type
  * @property {Record<string, unknown>} props
  * @property {Instance} container
  * @property {Instance} instance

diff --git a/src/typedefs/PixiElements.js b/src/typedefs/PixiElements.js
diff --git a/src/typedefs/PixiElementsImpl.js b/src/typedefs/PixiElementsImpl.js
@@ -3,7 +3,6 @@ import { NameOverrides } from '../constants/NameOverrides.js';
 /** @typedef {typeof import('pixi.js')} PixiType */
 
 /** @typedef {import('./AutoFilteredKeys.js').AutoFilteredKeys} AutoFilteredKeys */
-/** @typedef {import('./PixiElements.js').PixiElements} PixiElements */
 /** @typedef {import('./PixiOptions.js').PixiOptions} PixiOptions */
 
 /**
@@ -15,7 +14,7 @@ import { NameOverrides } from '../constants/NameOverrides.js';
  * @typedef {{
  *  [K in AutoFilteredKeys as K extends keyof typeof NameOverrides ? typeof NameOverrides[K] : Uncapitalize<K>]:
  *      import('react').PropsWithChildren<
- *          PixiOptionsType<import('./ConstructorParams.js').ConstructorParams<PixiType[K]>>
+ *          Omit<PixiOptionsType<import('./ConstructorParams.js').ConstructorParams<PixiType[K]>>, 'children'>
  *          & { init?: import('./ConstructorParams.js').ConstructorParams<PixiType[K]> }
  *      > & import('react').PropsWithRef<{ ref?: import('react').MutableRefObject<InstanceType<PixiType[K]>> }>
  * }} PixiElementsImpl