Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip webextension-polyfill #123

Closed
wants to merge 5 commits into from
Closed

Skip webextension-polyfill #123

wants to merge 5 commits into from

Conversation

fregante
Copy link
Collaborator

The polyfill provides little benefit here, especially since we're not dealing with Firefox anymore. Once we switch to MV3 we will be able to drop the polyfill completely, everywhere.

Not yet tested

@fregante fregante closed this Jan 28, 2023
@fregante fregante reopened this Feb 3, 2023
@fregante
Copy link
Collaborator Author

Context

webextension-polyfill is an abstraction that introduces bugs and limits, while providing little advantage (once MV3 rolls in), for example:

Status

This PR fixes some issues, but is now abandoned until we're able to use MV3 exclusively.

webextension-polyfill wraps response errors and rejects the promise returned by sendMessage(). Dropping the polyfill at this point means reimplementing this logic on top of webext-polyfill-kinda.

This isn't too difficult, but it's probably not necessary once we can use the natively-promised sendMessage in MV3 — or at the very least it would require further work to adjust it again.

Future

  • Drop webext-polyfill-kinda
  • Fix remaining broken tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

If a tab is closed before the method responds, the Messenger throws "Could not establish connection"
1 participant