Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntelliJ nx console plugin settings file to git #9515

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Nov 13, 2024

What does this PR do?

Demo

image

Discussion

  • Not sure why nx is create an Angular-framework configuration file. Perhaps that's their default if you don't have: https://nx.dev/nx-api/react

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (8318d74) to head (7843e8b).
Report is 502 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9515      +/-   ##
==========================================
+ Coverage   74.24%   75.79%   +1.54%     
==========================================
  Files        1332     1422      +90     
  Lines       40817    42913    +2096     
  Branches     7634     7899     +265     
==========================================
+ Hits        30306    32525    +2219     
+ Misses      10511    10388     -123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Playwright test results

passed  151 passed
flaky  3 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  11 minutes, 17 seconds
commit  7843e8b
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user
msedge › tests/runtime/modVariables/variableSync.spec.ts › Mod Variable Sync › session variable cross-tab sync
chrome › tests/telemetry/errors.spec.ts › can report an indexdb error to telemetry service

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit d9031ec into main Nov 13, 2024
24 checks passed
@twschiller twschiller deleted the feature/nx-console branch November 13, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants