Refactoring common tsconfig #9507
Conversation
| // You can see the full details at https://github.com/sindresorhus/tsconfig/blob/main/tsconfig.json | ||
| // Note: `strict: true` enables many flags that aren’t explicitly listed in that file | ||
| "extends": "@sindresorhus/tsconfig", |
There was a problem hiding this comment.
We might want to consider just copying the relevant config values to make them more explicit. We override a fair bit of these anyways
| "outDir": null, | ||
| "declaration": false, | ||
|
|
||
| // TODO: Drop these lines to make TS stricter https://github.com/pixiebrix/pixiebrix-extension/issues/775 |
There was a problem hiding this comment.
NIT: we should consider making some of these stricter in the base config (would require discussion of style)
There was a problem hiding this comment.
They've been on my radar for post strictNullChecks
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9507 +/- ##
==========================================
+ Coverage 74.24% 75.84% +1.59%
==========================================
Files 1332 1415 +83
Lines 40817 42793 +1976
Branches 7634 7884 +250
==========================================
+ Hits 30306 32455 +2149
+ Misses 10511 10338 -173 ☔ View full report in Codecov by Sentry. |
Playwright test results
Details
Flaky testschrome › tests/modLifecycle.spec.ts › create, run, package, and update mod Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
What does this PR do?
For more information on our expectations for the PR process, see the
code review principles doc