-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eslint config for libraries/utils
#9506
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9506 +/- ##
==========================================
+ Coverage 74.24% 75.81% +1.56%
==========================================
Files 1332 1413 +81
Lines 40817 42769 +1952
Branches 7634 7881 +247
==========================================
+ Hits 30306 32426 +2120
+ Misses 10511 10343 -168 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Flaky testsmsedge-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
/* eslint-disable-next-line no-restricted-syntax -- | ||
* Type to be preferred over a plain `object` | ||
* https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/ban-types.md */ | ||
type UnknownObject = Record<string, unknown>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another one of those things that we can to duplicate for now, but eventually we should move to a top level shared types module
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
libraries/utils
eslint-config-pixiebrix
. There are some rules (e.g., about nullish, etc. that aren't enforced)Future Work
lint
should likely run all checks (instead of having to runlint:full
)For more information on our expectations for the PR process, see the
code review principles doc