Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint config for libraries/utils #9506

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Nov 12, 2024

What does this PR do?

  • Add eslint config for libraries/utils
  • Current enforces base eslint-config-pixiebrix. There are some rules (e.g., about nullish, etc. that aren't enforced)

Future Work

For more information on our expectations for the PR process, see the
code review principles doc

@twschiller twschiller self-assigned this Nov 12, 2024
@twschiller twschiller added this to the 2.2.0 milestone Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (8318d74) to head (e02e7b3).
Report is 490 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9506      +/-   ##
==========================================
+ Coverage   74.24%   75.81%   +1.56%     
==========================================
  Files        1332     1413      +81     
  Lines       40817    42769    +1952     
  Branches     7634     7881     +247     
==========================================
+ Hits        30306    32426    +2120     
+ Misses      10511    10343     -168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Playwright test results

passed  152 passed
flaky  2 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  11 minutes, 4 seconds
commit  e02e7b3
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user
chrome › tests/modLifecycle.spec.ts › create, run, package, and update mod

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@twschiller twschiller marked this pull request as ready for review November 12, 2024 17:16
/* eslint-disable-next-line no-restricted-syntax --
* Type to be preferred over a plain `object`
* https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/ban-types.md */
type UnknownObject = Record<string, unknown>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another one of those things that we can to duplicate for now, but eventually we should move to a top level shared types module

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit daaff22 into main Nov 12, 2024
27 checks passed
@twschiller twschiller deleted the feature/eslint-workspaces branch November 12, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants