Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark extension dist directory as excluded in IntelliJ #9504

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Nov 12, 2024

What does this PR do?

  • Mark extension dist directory as excluded from IntelliJ search/find

Discussion

  • @fungairino this would be a good step to add in our monorepo migration guide

For more information on our expectations for the PR process, see the
code review principles doc

@twschiller twschiller self-assigned this Nov 12, 2024
@twschiller twschiller changed the title Mark extension dist directory as excluded Mark extension dist directory as excluded in IntelliJ Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (8318d74) to head (d905949).
Report is 486 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9504      +/-   ##
==========================================
+ Coverage   74.24%   75.79%   +1.54%     
==========================================
  Files        1332     1414      +82     
  Lines       40817    42789    +1972     
  Branches     7634     7883     +249     
==========================================
+ Hits        30306    32433    +2127     
+ Misses      10511    10356     -155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Playwright test results

passed  152 passed
flaky  2 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  10 minutes, 44 seconds
commit  d905949
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
msedge › tests/runtime/modVariables/variableSync.spec.ts › Mod Variable Sync › session variable cross-tab sync

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit c04bfe5 into main Nov 12, 2024
24 checks passed
@twschiller twschiller deleted the feature/intellij-exclude-dist branch November 12, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants