Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9429 Initializing npm workspace for extension application #9444

Merged
merged 14 commits into from
Nov 11, 2024

Conversation

fungairino
Copy link
Collaborator

@fungairino fungairino commented Nov 8, 2024

What does this PR do?

  • Closes Slice 1: Set up initial npm workspace and directory structure #9429
  • Moving pixiebrix extension to a npm workspace under /applications/browser-extension
  • Storybook was tested locally and it works.
  • Root package.json created (named "@pixiebrix/source")
  • Knip is temporarily removed since it requires more work to set up and run from the root.

Discussion

  • PR Vendors check failing is expected since these files were moved

Checklist

  • Verify pinning this change to the app
  • Fix coverage generation / uploading
  • Figure out why vercel deployment is failing

For more information on our expectations for the PR process, see the
code review principles doc

@fungairino fungairino changed the title Initializing npm workspace for extension application #9429 Initializing npm workspace for extension application Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Playwright test results

passed  150 passed
flaky  4 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  11 minutes, 40 seconds
commit  7eb722f
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user
chrome › tests/pageEditor/brickActions.spec.ts › brick actions panel behavior
msedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
msedge › tests/runtime/sidebar/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@fungairino fungairino marked this pull request as ready for review November 9, 2024 00:46
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.68%. Comparing base (8318d74) to head (7eb722f).
Report is 479 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9444      +/-   ##
==========================================
+ Coverage   74.24%   75.68%   +1.43%     
==========================================
  Files        1332     1406      +74     
  Lines       40817    42418    +1601     
  Branches     7634     7813     +179     
==========================================
+ Hits        30306    32102    +1796     
+ Misses      10511    10316     -195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller twschiller added this to the 2.1.8 milestone Nov 9, 2024
@fungairino
Copy link
Collaborator Author

I confirmed we can install this version of the extension in the app using gitpkg like so:

"@pixiebrix/extension": "https://gitpkg.vercel.app/pixiebrix/pixiebrix-extension/applications/browser-extension?810302c4a83786324c5179b46bcad6eac4e23b41",

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@fungairino fungairino merged commit f4c9911 into main Nov 11, 2024
22 of 24 checks passed
@fungairino fungairino deleted the npm-workspace branch November 11, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants