-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9429 Initializing npm workspace for extension application #9444
Conversation
Playwright test resultsDetails Open report ↗︎ Flaky testschrome-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9444 +/- ##
==========================================
+ Coverage 74.24% 75.68% +1.43%
==========================================
Files 1332 1406 +74
Lines 40817 42418 +1601
Branches 7634 7813 +179
==========================================
+ Hits 30306 32102 +1796
+ Misses 10511 10316 -195 ☔ View full report in Codecov by Sentry. |
I confirmed we can install this version of the extension in the app using gitpkg like so:
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
/applications/browser-extension
Discussion
Checklist
For more information on our expectations for the PR process, see the
code review principles doc