Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filename/function names in the mods screen #8779

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jul 9, 2024

What does this PR do?

  • Update filename/function names in the mods screen to match naming conventions

Reviewer Notes

  • mapModComponentToModDefinition might be relevant/reused in upcoming work to eliminate standalone mod components
  • Does not touch activateExtension directory because we'll be axing that soon

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.25%. Comparing base (8318d74) to head (ebbe9e5).
Report is 31 commits behind head on main.

Files Patch % Lines
...ensionConsole/pages/mods/utils/useReactivateMod.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8779   +/-   ##
=======================================
  Coverage   74.24%   74.25%           
=======================================
  Files        1332     1332           
  Lines       40817    40866   +49     
  Branches     7634     7642    +8     
=======================================
+ Hits        30306    30344   +38     
- Misses      10511    10522   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 9, 2024

Playwright test results

passed  86 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  88 tests across 31 suites
duration  13 minutes, 16 seconds
commit  ebbe9e5

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

github-actions bot commented Jul 9, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit 150d658 into main Jul 9, 2024
21 checks passed
@twschiller twschiller deleted the feature/mods-screen-file-names branch July 9, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants