Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename locator to integrationConfigLocator #8776

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jul 8, 2024

What does this PR do?

  • Renames locator and related methods to integrationConfigLocator for clarity

Discussion

  • Keeps "locator" terminology to differentiate from "registry", which we've been using for packages

Future Work

  • Move functionality into the platform protocol where appropriate

For more information on our expectations for the PR process, see the
code review principles doc

@twschiller twschiller changed the title Rename locator to integrationConfigLocator Rename locator to integrationConfigLocator Jul 8, 2024
@twschiller twschiller requested a review from BLoe July 8, 2024 21:24
Copy link

github-actions bot commented Jul 8, 2024

Playwright test results

passed  86 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  88 tests across 31 suites
duration  13 minutes, 56 seconds
commit  9fa590c

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 16 lines in your changes missing coverage. Please review.

Project coverage is 74.24%. Comparing base (8318d74) to head (9fa590c).
Report is 29 commits behind head on main.

Files Patch % Lines
src/background/integrationConfigLocator.ts 50.00% 4 Missing ⚠️
src/integrations/integrationConfigLocator.ts 80.00% 3 Missing ⚠️
...ns/util/findSanitizedIntegrationConfigWithRetry.ts 71.42% 2 Missing ⚠️
src/background/auth/launchInteractiveOAuth2Flow.ts 0.00% 1 Missing ⚠️
src/components/integrations/AuthWidget.tsx 50.00% 1 Missing ⚠️
.../activateExtension/useCloudExtensionPermissions.ts 0.00% 1 Missing ⚠️
...ionConsole/pages/integrations/IntegrationsPage.tsx 0.00% 1 Missing ⚠️
...ionConsole/pages/packageEditor/useSubmitPackage.ts 50.00% 1 Missing ⚠️
src/integrations/autoConfigure.ts 50.00% 1 Missing ⚠️
src/integrations/util/permissionsHelpers.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8776      +/-   ##
==========================================
- Coverage   74.24%   74.24%   -0.01%     
==========================================
  Files        1332     1332              
  Lines       40817    40865      +48     
  Branches     7634     7642       +8     
==========================================
+ Hits        30306    30339      +33     
- Misses      10511    10526      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 9, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit a98eb0e into main Jul 9, 2024
21 checks passed
@twschiller twschiller deleted the feature/integration-config-locator branch July 9, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants