#8771 initial brick actions panel end to end test #8771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fungairino
changed the title
fungairino
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8771 +/- ##
==========================================
- Coverage 74.24% 74.24% -0.01%
==========================================
Files 1332 1332
Lines 40817 40866 +49
Branches 7634 7642 +8
==========================================
+ Hits 30306 30341 +35
- Misses 10511 10525 +14 ☔ View full report in Codecov by Sentry. |
Playwright test results
Details
Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
fungairino
commented
Jul 8, 2024
| await testStarterBrick.activate(); | ||
| await expect(pageEditorPage.brickActionsPanel.root).toBeVisible(); | ||
|
|
||
| await page.pause(); |
There was a problem hiding this comment.
oops. the linter should have caught this
…ng-pasting-and-moving-actions
…ng-pasting-and-moving-actions
grahamlangford
approved these changes
Jul 8, 2024
fungairino
deleted the
8596-brick-actions-panel-create-delete-copying-pasting-and-moving-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a new end-to-end test that verifies that the brick actions panel is displayed when a starter brick is selected. The PR also includes a new fixture for the test, a mod definition file named "brick-actions.yaml". Additionally, it adds a check in the mod editor to ensure that the mod definition contains the placeholder "{{ modId }}". Lastly, it introduces a method to get a starter brick from a mod in the mod listing panel.