Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type-fest's Tagged type for simple nominal types #8757

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jul 6, 2024

What does this PR do?

  • Use type-fest's Tagged type for simple nominal typing

Future Work

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.24%. Comparing base (8318d74) to head (dc5eac7).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8757      +/-   ##
==========================================
- Coverage   74.24%   74.24%   -0.01%     
==========================================
  Files        1332     1332              
  Lines       40817    40826       +9     
  Branches     7634     7635       +1     
==========================================
+ Hits        30306    30312       +6     
- Misses      10511    10514       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 6, 2024

Playwright test results

passed  84 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  86 tests across 30 suites
duration  12 minutes, 2 seconds
commit  dc5eac7

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@twschiller twschiller added this to the 2.0.5 milestone Jul 6, 2024
@twschiller twschiller changed the title Use type-fest's Tagged type for simple nominal typing Use type-fest's Tagged type for simple nominal types Jul 6, 2024
@fregante
Copy link
Contributor

fregante commented Jul 8, 2024

Figure out how to use with complex objects that are generated with cooky-cutter factories.

I believe you're talking about this:

I looked into this type back then too but I found this was a blocker

Copy link

github-actions bot commented Jul 8, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit b6a0cd1 into main Jul 8, 2024
21 checks passed
@twschiller twschiller deleted the feature/type-fest-tagged branch July 8, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants