Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8753: load deployments on tabs immediately on startup #8755

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jul 6, 2024

What does this PR do?

Future Work

  • Decide less confusing naming for page lifecycle (e.g., "load"/"reload" is ambiguous with window load, etc.)

Checklist

  • Added jest or playwright tests and/or storybook stories

For more information on our expectations for the PR process, see the
code review principles doc

@twschiller twschiller added this to the 2.0.5 milestone Jul 6, 2024
Copy link

github-actions bot commented Jul 6, 2024

Playwright test results

passed  81 passed
flaky  3 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  86 tests across 30 suites
duration  14 minutes
commit  bfdcc47

Flaky tests

edge › tests/deployments/deploymentActivation.spec.ts › activate a deployed mod in the extension console
edge › tests/extensionConsole/activation.spec.ts › can activate a mod with built-in integration
edge › tests/extensionConsole/modsPage.spec.ts › can open mod in the workshop

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@twschiller twschiller added the customer Required for a customer projct label Jul 6, 2024
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.25%. Comparing base (8318d74) to head (bfdcc47).
Report is 20 commits behind head on main.

Files Patch % Lines
src/contentScript/messenger/api.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8755   +/-   ##
=======================================
  Coverage   74.24%   74.25%           
=======================================
  Files        1332     1332           
  Lines       40817    40836   +19     
  Branches     7634     7638    +4     
=======================================
+ Hits        30306    30323   +17     
- Misses      10511    10513    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller twschiller added the enhancement New feature or request label Jul 6, 2024
@fungairino
Copy link
Collaborator

Did you manually verify these changes? If so, how?

Copy link

github-actions bot commented Jul 8, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit d59a323 into main Jul 8, 2024
21 checks passed
@twschiller twschiller deleted the feature/8753-deployment-startup branch July 8, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer Required for a customer projct enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Install/run mods on first deployment install on extension startup
2 participants