#8596: improving mod definition snapshot capabilities - diffing #8754
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8754 +/- ##
==========================================
- Coverage 74.24% 74.24% -0.01%
==========================================
Files 1332 1332
Lines 40817 40826 +9
Branches 7634 7635 +1
==========================================
+ Hits 30306 30312 +6
- Misses 10511 10514 +3 ☔ View full report in Codecov by Sentry. |
| const modListing = modsPage.modTableItemById(modId); | ||
| await expect(modsPage.modTableItemById(modId)).toContainText( | ||
| "version 1.0.1", | ||
| ); | ||
| await modsPage.actionForModByName(modId, "Reactivate"); | ||
|
|
||
| await expect( | ||
| modListing.getByRole("button", { name: "Update" }), | ||
| ).toBeVisible(); | ||
| await modListing.getByRole("button", { name: "Update" }).click(); |
There was a problem hiding this comment.
I was pretty confused by this behavior as I reviewed this code making sure it worked with the new snapshot utility. It turns out that this "Update" button was only showing up because we were interrupting the persistence of the mod when saving it in the workshop.
There was a problem hiding this comment.
fyi @grahamlangford
Playwright test results
Details
Flaky testsedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
twschiller
changed the title
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
Adds capabilities for comparing snapshots of mod definitions within end-to-end tests, improving the readability and focus of what is being tested. The new functionality will track the mod definition each time the snapshot is checked, and can be used even if the mod was not created via the
modDefinitionNamesfixture.While writing this PR I also cleaned up some flaky behavior in editWorkshopModPage.ts which required some changes in the lifecycle spec.
Checklist
Leave all that are relevant and check off as completed
For more information on our expectations for the PR process, see the
code review principles doc