Improve Page Editor utils method names #8752
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8752 +/- ##
==========================================
- Coverage 74.24% 74.24% -0.01%
==========================================
Files 1332 1332
Lines 40817 40826 +9
Branches 7634 7635 +1
==========================================
+ Hits 30306 30312 +6
- Misses 10511 10514 +3 ☔ View full report in Codecov by Sentry. |
| @@ -252,14 +265,3 @@ export function selectPageEditorDimensions() { | |||
| window.innerWidth > window.innerHeight ? "landscape" : "portrait", | |||
| }; | |||
| } | |||
|
|
|||
| export function selectModMetadata( | |||
There was a problem hiding this comment.
Moved to collocate with other mod metadata-related methods
Playwright test results
Details
Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
| @@ -44,6 +44,17 @@ import AddDynamicTextSnippet from "@/bricks/effects/AddDynamicTextSnippet"; | |||
| import { type PackageUpsertResponse } from "@/types/contract"; | |||
| import { type UnsavedModDefinition } from "@/types/modDefinitionTypes"; | |||
|
|
|||
| export function mapModDefinitionUpsertResponseToModMetadata( | |||
There was a problem hiding this comment.
nit: are we also referring to Packages as ModDefinitions? Maybe this could instead be mapPackageUpsertResponseToMod(Definition)Metadata
There was a problem hiding this comment.
are we also referring to Packages as ModDefinitions
Packages is anything in the registry (could be a mod definition, brick definition, integration definition)
| // XXX: this may be not a reliable way to determine if the annotation | ||
| // is owned by the block or its sub pipeline. | ||
| // is owned by the brick or its sub pipeline. | ||
| // It assumes that it's only the pipeline field that can have a ".__value__" followed by "." in the path, | ||
| // and a pipeline field always has this pattern in its path. | ||
| return !restPath.includes(".__value__."); |
There was a problem hiding this comment.
side note: I hate this 🤢
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
selectoutside of Redux contextFor more information on our expectations for the PR process, see the
code review principles doc