-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8606 refactor files in pageEditor/ directory root #8749
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8749 +/- ##
==========================================
- Coverage 74.24% 74.24% -0.01%
==========================================
Files 1332 1332
Lines 40817 40825 +8
Branches 7634 7635 +1
==========================================
+ Hits 30306 30311 +5
- Misses 10511 10514 +3 ☔ View full report in Codecov by Sentry. |
src/tsconfig.strictNullChecks.json
Outdated
@@ -1113,7 +1113,7 @@ | |||
"./pageEditor/panes/insert/InsertButtonPane.tsx", | |||
"./pageEditor/panes/save/SaveDataIntegrityErrorModal.tsx", | |||
"./pageEditor/panes/save/saveHelpers.ts", | |||
"./pageEditor/panes/save/savingModComponentSlice.ts", | |||
"./pageEditor/store/savingModComponent/savingModComponentSlice.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I prefer a naming schema following something like:
/savingModComponent/slice
or using an index /savingModComponent/index
that exports a savingModComponentSlice
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Playwright test resultsDetails Open report ↗︎ Flaky testschrome › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
What does this PR do?
src/pageEditor
components #8606store/
andlayout/
directory