Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8611 Rename UIState types #8741

Merged
merged 14 commits into from
Jul 2, 2024
Merged

#8611 Rename UIState types #8741

merged 14 commits into from
Jul 2, 2024

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Jul 2, 2024 •
edited
Loading

What does this PR do?

@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.15385% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.25%. Comparing base (8318d74) to head (4e687f1).
Report is 4 commits behind head on main.

Files Patch % Lines
...elds/schemaFields/widgets/varPopup/SourceLabel.tsx 0.00% 4 Missing ⚠️
src/pageEditor/slices/editorSlice.ts 85.71% 3 Missing ⚠️
...geEditor/tabs/effect/useDocumentPreviewRunBlock.ts 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8741   +/-   ##
=======================================
  Coverage   74.24%   74.25%           
=======================================
  Files        1332     1332           
  Lines       40817    40830   +13     
  Branches     7634     7635    +1     
=======================================
+ Hits        30306    30319   +13     
  Misses      10511    10511

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

Playwright test results

passed  82 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  84 tests across 29 suites
duration  11 minutes, 51 seconds
commit  4e687f1

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@twschiller twschiller added this to the 2.0.5 milestone Jul 2, 2024
@mnholtz mnholtz marked this pull request as ready for review July 2, 2024 16:30
grahamlangford
grahamlangford reviewed Jul 2, 2024
View reviewed changes
src/components/fields/schemaFields/widgets/varPopup/SourceLabel.tsx Outdated
import { KnownSources } from "@/analysis/analysisVisitors/varAnalysis/varAnalysis";
import styles from "./SourceLabel.module.scss";
import { type TypedBrickMap } from "@/bricks/registry";

type SourceLabelProps = {
source: string;
extensionPointLabel: string;
blocksInfo: BlockInfo[];
blocksInfo: NodeInfo[];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: rename to match type

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@mnholtz mnholtz enabled auto-merge (squash) July 2, 2024 17:54
@mnholtz mnholtz merged commit 04144c1 into main Jul 2, 2024
18 checks passed
@mnholtz mnholtz deleted the feature/8611_rename_uistate_types branch July 2, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamlangford grahamlangford grahamlangford approved these changes

@BLoe BLoe Awaiting requested review from BLoe

@fungairino fungairino Awaiting requested review from fungairino

Assignees

@mnholtz mnholtz

Labels
developer experience page editor
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.

Rename Page Editor UIState types
3 participants
@mnholtz @grahamlangford @twschiller