#8581 refactoring POMs to use the BasePageObject #8727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fungairino
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8727 +/- ##
==========================================
+ Coverage 73.69% 74.24% +0.55%
==========================================
Files 1344 1332 -12
Lines 41566 40817 -749
Branches 7775 7634 -141
==========================================
- Hits 30633 30306 -327
+ Misses 10933 10511 -422 ☔ View full report in Codecov by Sentry. |
Playwright test results
Details
Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
mnholtz
reviewed
Jul 1, 2024
grahamlangford
approved these changes
Jul 1, 2024
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Switching over our POMs to use the BasePageObject, and simplifying page calls, locator definitions and constructors where applicable
In particular see how this BasePageObject makes defining the workshop modEditor POM very clean, and easy to nest.
Checklist
For more information on our expectations for the PR process, see the
code review principles doc