-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop tour starter brick and related bricks #8726
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8726 +/- ##
==========================================
+ Coverage 73.69% 74.23% +0.53%
==========================================
Files 1344 1333 -11
Lines 41566 40840 -726
Branches 7775 7632 -143
==========================================
- Hits 30633 30317 -316
+ Misses 10933 10523 -410 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Failed testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
23be065
to
3389898
Compare
* e2e test for background error telemetry * pr feedback * rename * fix error not being emitted in bg
* base page object model for proxying locator calls * wip * simplify base page object * fix unbound methods * add more documentation Drop dead code Fix regression in useAutoInsert Remove tourRunDatabase
3389898
to
7c92e21
Compare
Closing because Github is in a bad state |
What does this PR do?
Remaining Work
For more information on our expectations for the PR process, see the
code review principles doc