Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop tour starter brick and related bricks #8726

Closed
wants to merge 4 commits into from

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jun 28, 2024

What does this PR do?

Remaining Work

For more information on our expectations for the PR process, see the
code review principles doc

@twschiller twschiller marked this pull request as ready for review June 28, 2024 21:16
@twschiller twschiller added do not merge Merging of this PR is blocked by another one developer experience labels Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 80.74324% with 57 lines in your changes missing coverage. Please review.

Project coverage is 74.23%. Comparing base (c32e86f) to head (23be065).
Report is 66 commits behind head on main.

Current head 23be065 differs from pull request most recent head 7c92e21

Please upload reports for the commit 7c92e21 to get more accurate results.

Files Patch % Lines
src/pageEditor/starterBricks/quickBarProvider.ts 0.00% 10 Missing ⚠️
src/pageEditor/starterBricks/quickBar.ts 20.00% 8 Missing ⚠️
src/pageEditor/hooks/useResetModComponent.ts 25.00% 6 Missing ⚠️
src/pageEditor/starterBricks/contextMenu.ts 40.00% 6 Missing ⚠️
src/bricks/effects/tourEffect.ts 84.00% 4 Missing ⚠️
src/mods/useMods.ts 90.24% 4 Missing ⚠️
...pageEditor/hooks/useUpsertModComponentFormState.ts 72.72% 3 Missing ⚠️
src/pageEditor/starterBricks/adapter.ts 80.00% 3 Missing ⚠️
src/permissions/modComponentPermissionsHelpers.ts 80.00% 3 Missing ⚠️
src/pageEditor/hooks/useResetMod.ts 33.33% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8726      +/-   ##
==========================================
+ Coverage   73.69%   74.23%   +0.53%     
==========================================
  Files        1344     1333      -11     
  Lines       41566    40840     -726     
  Branches     7775     7632     -143     
==========================================
- Hits        30633    30317     -316     
+ Misses      10933    10523     -410     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 28, 2024

Playwright test results

failed  2 failed
passed  80 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  84 tests across 29 suites
duration  12 minutes, 51 seconds
commit  23be065

Failed tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
edge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

* e2e test for background error telemetry

* pr feedback

* rename

* fix error not being emitted in bg
* base page object model for proxying locator calls

* wip

* simplify base page object

* fix unbound methods

* add more documentation

Drop dead code

Fix regression in useAutoInsert

Remove tourRunDatabase
@twschiller
Copy link
Contributor Author

Closing because Github is in a bad state

@twschiller twschiller closed this Jun 30, 2024
@twschiller twschiller deleted the feature/drop-tour-starter-brick branch July 25, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience do not merge Merging of this PR is blocked by another one
Development

Successfully merging this pull request may close these issues.

2 participants