-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8614: rename remaining instances of recipe in the page editor #8724
#8614: rename remaining instances of recipe in the page editor #8724
Conversation
The change to get/setPageState blew up the PR more than I realized. I can revert that change to reduce the scope of the PR if needed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main pixiebrix/pixiebrix-extension#8724 +/- ##
==========================================
+ Coverage 73.69% 74.08% +0.38%
==========================================
Files 1344 1342 -2
Lines 41566 41387 -179
Branches 7775 7753 -22
==========================================
+ Hits 30633 30661 +28
+ Misses 10933 10726 -207 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
src/pageEditor/tabs/editTab/dataPanel/tabs/PageStateTab.test.tsx
Outdated
Show resolved
Hide resolved
src/pageEditor/tabs/editTab/dataPanel/tabs/__snapshots__/PageStateTab.test.tsx.snap
Show resolved
Hide resolved
…8614-rename-remaining-instances-of-recipe-in-the-page-editor
What does this PR do?
Future Work
BaseFormState
to changerecipe
key tomod
For more information on our expectations for the PR process, see the
code review principles doc