Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8614: rename remaining instances of recipe in the page editor #8724

Merged

Conversation

grahamlangford
Copy link
Collaborator

@grahamlangford grahamlangford commented Jun 28, 2024

What does this PR do?

Future Work

  • Redux Persist migration to change BaseFormState to change recipe key to mod

For more information on our expectations for the PR process, see the
code review principles doc

@grahamlangford grahamlangford linked an issue Jun 28, 2024 that may be closed by this pull request
@grahamlangford
Copy link
Collaborator Author

The change to get/setPageState blew up the PR more than I realized. I can revert that change to reduce the scope of the PR if needed

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 50.68493% with 72 lines in your changes missing coverage. Please review.

Project coverage is 74.08%. Comparing base (c32e86f) to head (1a4d726).
Report is 62 commits behind head on main.

Files Patch % Lines
src/pageEditor/starterBricks/base.ts 56.52% 10 Missing ⚠️
src/pageEditor/slices/editorSlice.ts 50.00% 9 Missing ⚠️
src/pageEditor/sidebar/Extensions.tsx 16.66% 5 Missing ⚠️
src/pageEditor/starterBricks/sidebar.ts 0.00% 5 Missing ⚠️
src/pageEditor/starterBricks/tour.ts 0.00% 5 Missing ⚠️
src/pageEditor/starterBricks/trigger.ts 0.00% 5 Missing ⚠️
...c/pageEditor/sidebar/DraftModComponentListItem.tsx 20.00% 4 Missing ⚠️
src/pageEditor/sidebar/modals/AddToModModal.tsx 42.85% 4 Missing ⚠️
...rc/pageEditor/sidebar/modals/SaveAsNewModModal.tsx 40.00% 3 Missing ⚠️
src/pageEditor/starterBricks/contextMenu.ts 0.00% 3 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    pixiebrix/pixiebrix-extension#8724      +/-   ##
==========================================
+ Coverage   73.69%   74.08%   +0.38%     
==========================================
  Files        1344     1342       -2     
  Lines       41566    41387     -179     
  Branches     7775     7753      -22     
==========================================
+ Hits        30633    30661      +28     
+ Misses      10933    10726     -207     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 28, 2024

Playwright test results

passed  80 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  82 tests across 29 suites
duration  10 minutes, 51 seconds
commit  1a4d726

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@grahamlangford grahamlangford merged commit 96d7758 into main Jun 28, 2024
18 checks passed
@grahamlangford grahamlangford deleted the 8614-rename-remaining-instances-of-recipe-in-the-page-editor branch June 28, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Rename remaining instances of "recipe" in the Page Editor
3 participants