-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor lifecycle module names #8708
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8708 +/- ##
==========================================
+ Coverage 73.69% 73.74% +0.05%
==========================================
Files 1344 1348 +4
Lines 41566 41728 +162
Branches 7775 7807 +32
==========================================
+ Hits 30633 30774 +141
- Misses 10933 10954 +21 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Much easier to reason about with some of these name changes.
For the install/uninstall debate, I'm partial to attach/detach. I've run the concept through ChatGPT for other ideas, but attach still seems to be the best I've seen that's not overloading terms we use elsewhere. The few places we use attach
in the existing codebase seem fairly consistent with the behavior we mean when attaching a starter brick
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
StarterBrick.install
,StarterBrick.runModComponents
StarterBrick.removeModComponent
Future
For more information on our expectations for the PR process, see the
code review principles doc