#8343: handle 4 digit extension version numbers

[grahamlangford]

What does this PR do?

• Fixes New version number format causes extension not to start #8343

Reviewer Tips

• See src/types/helpers.ts and src/utils/extensionUtils.ts first

Discussion

• Looked into enforcing an ExtensionsVersionString type using a brand, but ran into too many conflicts withSemVerString

Demo

https://www.loom.com/share/a06553e9794042489c035989b2505b76

Future Work

• Consider a linting rule to prefer getExtensionVersion() to browser.runtime.getManifest().version

Checklist

• Add jest or playwright tests and/or storybook stories
• Designate a primary reviewer @twschiller

[codecov]

Codecov Report

Attention: Patch coverage is 86.53846% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 73.50%. Comparing base (9d0a15e) to head (24bbb97).

Files	Patch %	Lines
src/background/telemetry.ts	60.00%	2 Missing ⚠️
src/background/installer.ts	66.66%	1 Missing ⚠️
src/background/messenger/external/api.ts	0.00%	1 Missing ⚠️
src/extensionConsole/pages/UpdateBanner.tsx	50.00%	1 Missing ⚠️
src/extensionPages/extensionPagePlatform.ts	0.00%	1 Missing ⚠️
src/types/helpers.ts	93.75%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8346   +/-   ##
=======================================
  Coverage   73.49%   73.50%           
=======================================
  Files        1330     1330           
  Lines       41113    41131   +18     
  Branches     7636     7643    +7     
=======================================
+ Hits        30217    30233   +16     
- Misses      10896    10898    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[twschiller]

The types continue to be super-sketchy (e.g., the "allowV" producing an invalid SemVerString). But this PR seems OK. Approving to unblock E2E testing

I ran a quick search for getManifest() and didn't spot any places where we were reading the version

[github-actions]

When the PR is merged, the first loom link found on this PR will be posted to #sprint-demo on Slack. Do not edit this comment manually.