Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up restricted zones warning in code base to enforce separation of concerns #5447

Closed
twschiller opened this issue Mar 31, 2023 · 4 comments

Comments

@twschiller
Copy link
Contributor

twschiller commented Mar 31, 2023

Context

  • We have an eslint rule to prevent separation of concerns:
    ].map((exporter) => ({
  • We introduced it to avoid issues importing code in contexts (contentScript, options page, etc.) that is not allowed by the Web Extension API model
  • We can also use it to enforce separation of concerns between code modules

Steps to Reproduce

npm run lint -- --rule '{"import/no-restricted-paths": 2}'

Main sources of violations

  • @/pageEditor/slices/editorSlice and related code
  • @/contentScript/elementReference and related code
  • @/pageScript/framework and related code
  • @/pageEditor/testHelpers when used to test components in the context of a Page Editor form state
    • Proposed solution: allow use of @/pageEditor/testHelpers in .test.tsx files
  • Analysis folder references Page Editor state. Ideally analysis folder is independent. (In future will want to run on server outside of extension context)
@BLoe
Copy link
Contributor

BLoe commented Jun 27, 2023

Related: #4887

Copy link

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

Copy link

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

@github-actions github-actions bot added the Stale label Apr 23, 2024
Copy link

github-actions bot commented May 1, 2024

This issue was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants