Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid expectContext/forbidContext in folders that already enforce it #193

Open
fregante opened this issue Jan 21, 2024 · 2 comments
Open

Forbid expectContext/forbidContext in folders that already enforce it #193

fregante opened this issue Jan 21, 2024 · 2 comments
Labels
developer experience enhancement New feature or request

Comments

@fregante
Copy link
Collaborator

no-restricted-paths already enforces context and makes the build fail if they're imported by the wrong context.

expectContext/forbidContext calls are redundant. Can we drop them?
@fregante fregante added the enhancement New feature or request label Jan 21, 2024
@fregante
Copy link
Collaborator Author

fregante commented Jan 21, 2024 •
edited
Loading

It looks like there are 158 errors for no-restricted-paths so this isn't safe yet :(

Most of them are actually due to "shared code" (like bricks) importing from context-specific folders, which is "fine" since they're run from that context to begin with.

Related:

@fregante fregante mentioned this issue Jan 21, 2024
Merged
2 tasks
@grahamlangford
Copy link
Collaborator

Related issue: #123

@fregante fregante mentioned this issue Feb 7, 2024
Closed
@fregante fregante mentioned this issue Feb 25, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developer experience enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fregante @grahamlangford