pr feedback

pixiebrix · Jul 9, 2024 · fdc71b0 · fdc71b0
1 parent 6c53fef
commit fdc71b0
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/end-to-end-tests/pageObjects/pageEditor/modListingPanel.ts b/end-to-end-tests/pageObjects/pageEditor/modListingPanel.ts
@@ -32,7 +32,7 @@ export class ModListItem extends BasePageObject {
     return this.getByLabel(" - Ellipsis");
   }
 
-  async activate() {
+  async select() {
     return this.click();
   }
 }

diff --git a/end-to-end-tests/pageObjects/pageEditor/pageEditorPage.ts b/end-to-end-tests/pageObjects/pageEditor/pageEditorPage.ts
@@ -124,7 +124,7 @@ export class PageEditorPage extends BasePageObject {
 
   async saveStandaloneMod(modName: string) {
     const modListItem = this.modListingPanel.getModListItemByName(modName);
-    await modListItem.activate();
+    await modListItem.select();
     await modListItem.saveButton.click();
     await expect(this.getByText("Saved Mod")).toBeVisible();
     this.savedStandaloneModNames.push(modName);

diff --git a/end-to-end-tests/tests/pageEditor/brickActions.spec.ts b/end-to-end-tests/tests/pageEditor/brickActions.spec.ts
@@ -42,19 +42,19 @@ test("brick actions panel behavior", async ({
   });
 
   const { brickActionsPanel } = pageEditorPage;
-  await test.step("Activate a mod and verify brick actions panel is hidden", async () => {
+  await test.step("Select the mod in the page editor and verify brick actions panel is hidden", async () => {
     const modListItem =
       pageEditorPage.modListingPanel.getModListItemByName("Mod Actions Test");
-    await modListItem.activate();
+    await modListItem.select();
     await expect(brickActionsPanel.root).toBeHidden();
   });
 
-  await test.step("Activate starter brick and verify brick actions panel is visible", async () => {
+  await test.step("Select the starter brick and verify brick actions panel is visible", async () => {
     const testStarterBrick = pageEditorPage.modListingPanel.getModStarterBrick(
       "Mod Actions Test",
       "Button",
     );
-    await testStarterBrick.activate();
+    await testStarterBrick.select();
     await expect(brickActionsPanel.root).toBeVisible();
   });
 

diff --git a/end-to-end-tests/tests/pageEditor/saveMod.spec.ts b/end-to-end-tests/tests/pageEditor/saveMod.spec.ts
@@ -58,7 +58,7 @@ test("shows error notification when updating a public mod without incrementing t
   const pageEditorPage = await newPageEditorPage(page.url());
   const modListItem =
     pageEditorPage.modListingPanel.getModListItemByName(modName);
-  await modListItem.activate();
+  await modListItem.select();
   await pageEditorPage.modEditorPane.name.fill("8203 Repro Updated");
   await pageEditorPage.modListingPanel.activeModListItem.saveButton.click();
   await expect(pageEditorPage.getIncrementVersionErrorToast()).toBeVisible();