PR-related fixes

pixiebrix · Apr 25, 2024 · 0c221cf · 0c221cf
1 parent f49232d
commit 0c221cf
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/background/installer.ts b/src/background/installer.ts
@@ -105,9 +105,11 @@ export async function openInstallPage() {
   // Case 3: there's no Admin Console onboarding tab open
 
   if (appOnboardingTab) {
-    const appOnboardingTabUrl = new URL(appOnboardingTab.url ?? "");
+    const appOnboardingTabUrl = appOnboardingTab?.url
+      ? new URL(appOnboardingTab.url)
+      : null;
 
-    if (appOnboardingTabUrl.pathname === "/start") {
+    if (appOnboardingTabUrl?.pathname === "/start") {
       // Case 1a/1b: Admin Console is showing a partner onboarding flow
 
       const controlRoomHostname =

diff --git a/src/contentScript/pageEditor/selectElement.ts b/src/contentScript/pageEditor/selectElement.ts
@@ -38,7 +38,7 @@ export default async function selectElement({
   root?: string;
   excludeRandomClasses?: boolean;
 }): Promise<ElementInfo> {
-  const rootElements = $safeFind(root ?? "").get();
+  const rootElements = root ? $safeFind(root).get() : [];
 
   if (root && rootElements.length === 0) {
     throw new NoElementsFoundError(root);

diff --git a/src/extensionConsole/pages/UpdateBanner.tsx b/src/extensionConsole/pages/UpdateBanner.tsx
@@ -26,7 +26,7 @@ import { getExtensionVersion } from "@/utils/extensionUtils";
 
 // XXX: move this kind of async state to the Redux state.
 export function useUpdateAvailable(): boolean {
-  const { data: updateAvailable } = useAsyncState(async () => {
+  const { data: updateAvailable = false } = useAsyncState(async () => {
     try {
       const available = await getAvailableVersion();
       const installed = getExtensionVersion();
@@ -37,7 +37,7 @@ export function useUpdateAvailable(): boolean {
     }
   }, []);
 
-  return Boolean(updateAvailable);
+  return updateAvailable;
 }
 
 const UpdateBanner: React.FunctionComponent = () => {