extend size of address when file is larger than 4GB #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prigaux
requested changes
Jul 30, 2024
file.c
Outdated
| @@ -53,6 +53,18 @@ void openFile(void) | |||
| fileSize = 0; | |||
| } | |||
| biggestLoc = fileSize; | |||
|
|
|||
| // compute number of digits for address | |||
There was a problem hiding this comment.
I suggest adding a comment somewhere explaining that nAddrDigits max is 16 (max size is 2**64 and a hex char is 2**4 wide)
There was a problem hiding this comment.
Could you move this code to a function compute_nAddrDigits (or something alike)
display.c
Outdated
| @@ -162,6 +162,13 @@ void exitCurses(void) | |||
| endwin(); | |||
| } | |||
|
|
|||
| static void printaddr(uint64_t addr) | |||
| { | |||
| char templ[7]; | |||
There was a problem hiding this comment.
7 needs to be explained.
Afaik it is sizeof("%016lX") with 16 being the max nAddrDigits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the file size exceeds 4GB, the current 8 digits are not enough for the address and the display overflows.
This patch fixes #68.