Merge pull request #40 from fuzhenn/fix-transferable

fix missing geometry attributes in transferable
pissang · Jan 17, 2018 · c940d5a · c940d5a
2 parents 307692e + fa7cc34
commit c940d5a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/util/transferable.js b/src/util/transferable.js
@@ -93,18 +93,18 @@ var transferableUtil = {
             options.boundingBox = new BoundingBox(min, max);
         }
 
+        const geometry = new Geometry(options);
+
         //attributes
-        var attributes = {};
         for (var p in object.attributes) {
             if (object.attributes.hasOwnProperty(p)) {
                 var attr = object.attributes[p];
-                attributes[p] = new Geometry.Attribute(attr.name, attr.type, attr.size, attr.semantic);
-                attributes[p].value = attr.value;
+                geometry.attributes[p] = new Geometry.Attribute(attr.name, attr.type, attr.size, attr.semantic);
+                geometry.attributes[p].value = attr.value;
             }
         }
-        options.attributes = attributes;
 
-        return new Geometry(options);
+        return geometry;
     }
 
 }

diff --git a/test/unit/util/transferable.spec.js b/test/unit/util/transferable.spec.js
@@ -74,5 +74,7 @@ describe('util.transferable.Spec', function () {
         assert(geometry.getAttribute('position').value.length === 156);
         assert(geometry.getAttribute('texcoord0').value.length === 104);
         assert(geometry.getAttribute('normal').value.length === 156);
+        assert(geometry.getAttribute('texcoord0'));
+        assert(geometry.getAttribute('texcoord1'));
     });
 });