Skip to content

Commit

Permalink
Remove C++17 runs from CI
Browse files Browse the repository at this point in the history
Signed-off-by: Michal Siedlaczek <[email protected]>
  • Loading branch information
elshize committed Dec 9, 2024
1 parent cf0cc78 commit b3f381e
Show file tree
Hide file tree
Showing 15 changed files with 11 additions and 65 deletions.
31 changes: 4 additions & 27 deletions .github/workflows/commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,46 +2,23 @@ name: Commit

on:
push:
branches: [ master ]
branches: [ main ]
pull_request:
branches: [ master ]
branches: [ main ]

jobs:
test_cli:
runs-on: ${{ matrix.os }}
strategy:
matrix:
name: [linux-gcc-9]
name: [linux-gcc-13]
include:
- name: linux-gcc-9
- name: linux-gcc-13
os: ubuntu-22.04
compiler: "gcc"
version: "9"

steps:
- uses: actions/checkout@v2

- name: Install (Linux)
if: runner.os == 'Linux'
shell: bash
run: |
# Install compiler
cc="${{ matrix.compiler }}-${{ matrix.version }}"
cc="${cc%-}"
cxx="${cc/clang/clang++}"
cxx="${cxx/gcc/g++}"
sudo apt-get update
sudo apt-get install -y libtool m4 autoconf
if [ "${{ matrix.compiler }}" = "gcc" ]; then
sudo apt-get install -y "${cxx}"
else
sudo apt-get install -y "${cc}"
fi
echo "CC=${cc}" >> $GITHUB_ENV
echo "CXX=${cxx}" >> $GITHUB_ENV
- name: Install bats
if: runner.os == 'Linux'
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Publish Docker
on:
push:
branches: [ master ]
branches: [ main ]

jobs:
docker:
Expand All @@ -16,5 +16,5 @@ jobs:
-H "Travis-API-Version:3" \
-H "Accept:application/json" \
-H "Authorization:token ${{secrets.TRAVIS_API_TOKEN}}" \
-d '{"request":{"branch":"master"}}' \
-d '{"request":{"branch":"main"}}' \
'https://api.travis-ci.com/repo/pisa-engine%2Fdocker/requests'
8 changes: 2 additions & 6 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,14 @@ name: Pull Request

on:
pull_request:
branches: [ master ]
branches: [ main ]

jobs:
test:
runs-on: ubuntu-22.04
strategy:
matrix:
compiler: [gcc13, clang16]
standard: [17]
include:
- compiler: gcc13 # Extra test for C++20
standard: 20

steps:
- uses: actions/checkout@v2
Expand All @@ -23,7 +19,7 @@ jobs:
- name: Bulid docker image
shell: bash
run: |
docker build --build-arg CXX_STANDARD=${{matrix.standard}} \
docker build \
-t pisa -f- . < "${{runner.workspace}}/pisa/test/docker/${{matrix.compiler}}/Dockerfile"
- name: Test
Expand Down
11 changes: 3 additions & 8 deletions .github/workflows/trunk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Trunk

on:
push:
branches: [ master ]
branches: [ main ]

jobs:
test:
Expand All @@ -11,16 +11,12 @@ jobs:
matrix:
compiler: [gcc10, gcc11, gcc12, gcc13, clang15, clang16]
build_type: [Debug]
standard: [17]
sanitizers: [OFF]
include:
- compiler: gcc13 # Extra test for C++20
standard: 20
- compiler: gcc13 # Extra test for Release
build_type: Release
- compiler: clang16 # Extra test for C++20
standard: 20
sanitizers: ON # Also run with sanitizers
- compiler: clang16 # Extra test with sanitizers
sanitizers: ON

steps:
- uses: actions/checkout@v2
Expand All @@ -31,7 +27,6 @@ jobs:
shell: bash
run: |
docker build \
--build-arg CXX_STANDARD=${{matrix.standard}} \
--build-arg USE_SANITIZERS=${{matrix.sanitizers}} \
-t pisa -f- . < "${{runner.workspace}}/pisa/test/docker/${{matrix.compiler}}/Dockerfile"
Expand Down
2 changes: 0 additions & 2 deletions test/docker/benchmark/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM gcc:13

ARG CXX_STANDARD=17
ARG USE_SANITIZERS=OFF

ENV DEBIAN_FRONTEND=noninteractive
Expand All @@ -19,7 +18,6 @@ RUN cmake \
"-DPISA_ENABLE_TESTING=OFF" \
"-DPISA_ENABLE_BENCHMARKING=OFF" \
"-DUSE_SANITIZERS=$USE_SANITIZERS" \
"-DCMAKE_CXX_STANDARD=$CXX_STANDARD" \
.. \
&& cmake --build . --config Debug -- -j 4

Expand Down
1 change: 0 additions & 1 deletion test/docker/clang11/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM debian:bullseye

ARG CXX_STANDARD=17
ARG DEBIAN_FRONTEND=noninteractive

COPY . /pisa
Expand Down
2 changes: 0 additions & 2 deletions test/docker/clang12/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM debian:bullseye

ARG CXX_STANDARD=17
ARG USE_SANITIZERS=OFF
ARG DEBIAN_FRONTEND=noninteractive

Expand All @@ -17,7 +16,6 @@ RUN cmake \
-DPISA_ENABLE_BENCHMARKING='OFF' \
-DCMAKE_TOOLCHAIN_FILE='clang.cmake' \
"-DPISA_SANITIZERS=$USE_SANITIZERS" \
"-DCMAKE_CXX_STANDARD=$CXX_STANDARD" \
.. \
&& cmake --build . --config Debug -- -j 4

Expand Down
2 changes: 0 additions & 2 deletions test/docker/clang15/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM debian:bullseye

ARG CXX_STANDARD=17
ARG USE_SANITIZERS=OFF
ARG DEBIAN_FRONTEND=noninteractive
ARG BUILD_TYPE=Debug
Expand All @@ -23,7 +22,6 @@ RUN cmake \
-DPISA_SYSTEM_BOOST='ON' \
-DCMAKE_TOOLCHAIN_FILE='clang.cmake' \
"-DPISA_SANITIZERS=$USE_SANITIZERS" \
"-DCMAKE_CXX_STANDARD=$CXX_STANDARD" \
.. \
&& cmake --build . --config Debug -- -j 4

Expand Down
2 changes: 0 additions & 2 deletions test/docker/clang16/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM debian:bullseye

ARG CXX_STANDARD=17
ARG USE_SANITIZERS=OFF
ARG DEBIAN_FRONTEND=noninteractive
ARG BUILD_TYPE=Debug
Expand All @@ -23,7 +22,6 @@ RUN cmake \
-DPISA_SYSTEM_BOOST='ON' \
-DCMAKE_TOOLCHAIN_FILE='clang.cmake' \
"-DPISA_SANITIZERS=$USE_SANITIZERS" \
"-DCMAKE_CXX_STANDARD=$CXX_STANDARD" \
.. \
&& cmake --build . --config Debug -- -j 4

Expand Down
2 changes: 0 additions & 2 deletions test/docker/gcc10/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM gcc:10

ARG CXX_STANDARD=17
ARG USE_SANITIZERS=OFF
ARG BUILD_TYPE=Debug

Expand All @@ -17,7 +16,6 @@ RUN cmake \
"-DPISA_BUILD_TOOLS=OFF" \
"-DPISA_ENABLE_BENCHMARKING=OFF" \
"-DPISA_SANITIZERS=$USE_SANITIZERS" \
"-DCMAKE_CXX_STANDARD=$CXX_STANDARD" \
.. \
&& cmake --build . --config Debug -- -j 4

Expand Down
2 changes: 0 additions & 2 deletions test/docker/gcc11/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM gcc:11

ARG CXX_STANDARD=17
ARG USE_SANITIZERS=OFF
ARG BUILD_TYPE=Debug

Expand All @@ -17,7 +16,6 @@ RUN cmake \
"-DPISA_BUILD_TOOLS=OFF" \
"-DPISA_ENABLE_BENCHMARKING=OFF" \
"-DPISA_SANITIZERS=$USE_SANITIZERS" \
"-DCMAKE_CXX_STANDARD=$CXX_STANDARD" \
.. \
&& cmake --build . --config Debug -- -j 4

Expand Down
2 changes: 0 additions & 2 deletions test/docker/gcc12/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM gcc:12

ARG CXX_STANDARD=17
ARG USE_SANITIZERS=OFF
ARG BUILD_TYPE=Debug

Expand All @@ -17,7 +16,6 @@ RUN cmake \
"-DPISA_BUILD_TOOLS=OFF" \
"-DPISA_ENABLE_BENCHMARKING=OFF" \
"-DPISA_SANITIZERS=$USE_SANITIZERS" \
"-DCMAKE_CXX_STANDARD=$CXX_STANDARD" \
.. \
&& cmake --build . --config Debug -- -j 4

Expand Down
2 changes: 0 additions & 2 deletions test/docker/gcc13/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM gcc:13

ARG CXX_STANDARD=17
ARG USE_SANITIZERS=OFF
ARG BUILD_TYPE=Debug

Expand All @@ -17,7 +16,6 @@ RUN cmake \
"-DPISA_BUILD_TOOLS=OFF" \
"-DPISA_ENABLE_BENCHMARKING=OFF" \
"-DPISA_SANITIZERS=$USE_SANITIZERS" \
"-DCMAKE_CXX_STANDARD=$CXX_STANDARD" \
.. \
&& cmake --build . --config Debug -- -j 4

Expand Down
2 changes: 0 additions & 2 deletions test/docker/gcc9/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM gcc:9

ARG CXX_STANDARD=17
ARG USE_SANITIZERS=OFF

ENV DEBIAN_FRONTEND=noninteractive
Expand All @@ -16,7 +15,6 @@ RUN cmake \
"-DPISA_BUILD_TOOLS=OFF" \
"-DPISA_ENABLE_BENCHMARKING=OFF" \
"-DPISA_SANITIZERS=$USE_SANITIZERS" \
"-DCMAKE_CXX_STANDARD=$CXX_STANDARD" \
.. \
&& cmake --build . --config Debug -- -j 4

Expand Down
3 changes: 0 additions & 3 deletions test/docker/system-deps/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
FROM gcc:13

ARG CXX_STANDARD=17

ENV DEBIAN_FRONTEND=noninteractive
ENV TZ=America/New_York

Expand Down Expand Up @@ -32,7 +30,6 @@ RUN cmake \
"-DPISA_SYSTEM_ONETBB=ON" \
"-DPISA_SYSTEM_BOOST=ON" \
"-DPISA_SYSTEM_CLI11=ON" \
"-DCMAKE_CXX_STANDARD=$CXX_STANDARD" \
.. \
&& cmake --build . --config Debug -- -j 4

Expand Down

0 comments on commit b3f381e

Please sign in to comment.