enhancement of Azure service #493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badbye
force-pushed
the
azure-context-agg
branch
from
76b9bbf to
5a83f8c
Compare
|
I suggest merge #496 first, cause it has more params for Azure TTS. |
kwindla
reviewed
Sep 25, 2024
src/pipecat/services/azure.py
Outdated
| @@ -77,6 +86,7 @@ def __init__( | |||
| region: str, | |||
| voice="en-US-SaraNeural", | |||
| sample_rate: int = 16000, | |||
| playback_rate: float = 1.0, | |||
There was a problem hiding this comment.
This will conflict with: https://github.com/pipecat-ai/pipecat/pull/496/files
Perhaps we should merge that PR, and then add playback_rate?
There was a problem hiding this comment.
Yes. #496 already has a rate parameter to control the playback rate. I just removed my implementation.
badbye
force-pushed
the
azure-context-agg
branch
from
5a83f8c to
5516511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_context_aggregatormethod toBaseOpenAILLMService, so thatAzureLLMServicealso has this method