Introduce support for extracting and processing grounding metadata from GoogleLLMService. #1030
+235
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipi87
changed the title
filipi87
commented
Jan 17, 2025
filipi87
commented
Jan 20, 2025
| @@ -720,6 +782,14 @@ async def _process_context(self, context: OpenAILLMContext): | |||
| except Exception as e: | |||
| logger.exception(f"{self} exception: {e}") | |||
| finally: | |||
| if grounding_metadata is not None and isinstance(grounding_metadata, dict): | |||
| llm_search_frame = LLMSearchResponseFrame( | |||
There was a problem hiding this comment.
One nice improvement would be to create an RTVI message so we can share this response with the RTVI clients. What do you think? I can create a follow-up PR to implement the message.
There was a problem hiding this comment.
Maybe something like: RTVIBotLLMSearchResponse.
What do you think ?
There was a problem hiding this comment.
I have included it in this PR: #1051
…om Google LLM responses.
filipi87
force-pushed
the
gemini_grounding_metadata
branch
from
2d14532 to
9b61633
Compare
filipi87
changed the title
filipi87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for extracting and processing grounding metadata from Google LLM responses.
Created an example using Google Search using GoogleLLMService.