Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade linters #2985

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Upgrade linters #2985

wants to merge 11 commits into from

Conversation

joeturki
Copy link
Member

@joeturki joeturki commented Jan 2, 2025

Description

Upgrade the linters, I will ignore those that require refactor (will be addressed in a separate PR).

Reference PR

pion/.goassets#220

@joeturki joeturki mentioned this pull request Jan 2, 2025
19 tasks
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 34 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (1ee0299) to head (875f2bb).

Files with missing lines Patch % Lines
peerconnection.go 88.88% 4 Missing and 8 partials ⚠️
pkg/media/oggwriter/oggwriter.go 55.55% 4 Missing ⚠️
sdp.go 93.93% 0 Missing and 4 partials ⚠️
pkg/media/ivfwriter/ivfwriter.go 0.00% 3 Missing ⚠️
pkg/media/rtpdump/rtpdump.go 81.25% 0 Missing and 3 partials ⚠️
rtpreceiver.go 60.00% 0 Missing and 2 partials ⚠️
track_local_static.go 87.50% 1 Missing and 1 partial ⚠️
icetransport.go 87.50% 0 Missing and 1 partial ⚠️
pkg/media/ivfreader/ivfreader.go 66.66% 0 Missing and 1 partial ⚠️
pkg/media/oggreader/oggreader.go 92.85% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2985      +/-   ##
==========================================
- Coverage   77.93%   77.83%   -0.11%     
==========================================
  Files          89       89              
  Lines       10546    10547       +1     
==========================================
- Hits         8219     8209      -10     
- Misses       1838     1845       +7     
- Partials      489      493       +4     
Flag Coverage Δ
go 79.39% <90.00%> (-0.12%) ⬇️
wasm 63.50% <85.56%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iceserver_test.go Outdated Show resolved Hide resolved
@Sean-Der
Copy link
Member

Sean-Der commented Jan 2, 2025

Amazing! This is exactly what we need @joeturki

If you are overwhelmed by the lints you can just upgrade versions/disable more and we can iterate on it!

.golangci.yml Outdated Show resolved Hide resolved
ignore-type-assert-ok: true
ignore-map-index-ok: true
ignore-chan-recv-ok: true
ignore-decls:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do ignore-decls because they are shared between repos :(

I really like this varnamelen. wg and pc are only things you are gonna know if you have wrote a lot of Go/WebRTC. This is really going to help people learn better!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do ignore-decls because they are shared between repos :(

Even if I only apply it to shared decls like n int? :( I don't think it's necessary for pc and wg anymore since I changed min-name-length to 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants