-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade linters #2985
base: master
Are you sure you want to change the base?
Upgrade linters #2985
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2985 +/- ##
==========================================
- Coverage 77.93% 77.83% -0.11%
==========================================
Files 89 89
Lines 10546 10547 +1
==========================================
- Hits 8219 8209 -10
- Misses 1838 1845 +7
- Partials 489 493 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Amazing! This is exactly what we need @joeturki If you are overwhelmed by the lints you can just upgrade versions/disable more and we can iterate on it! |
ignore-type-assert-ok: true | ||
ignore-map-index-ok: true | ||
ignore-chan-recv-ok: true | ||
ignore-decls: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't do ignore-decls
because they are shared between repos :(
I really like this varnamelen
. wg
and pc
are only things you are gonna know if you have wrote a lot of Go/WebRTC. This is really going to help people learn better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't do ignore-decls because they are shared between repos :(
Even if I only apply it to shared decls like n int
? :( I don't think it's necessary for pc
and wg
anymore since I changed min-name-length
to 2.
Description
Upgrade the linters, I will ignore those that require refactor (will be addressed in a separate PR).
Reference PR
pion/.goassets#220